On Wed, May 23, 2018 at 02:46:52PM +0100, Alex Bennée wrote: > > Dave Martin <dave.mar...@arm.com> writes: > > > There are a number of bits of code sprinkled around the kernel to > > set a thread flag if a certain condition is true, and clear it > > otherwise. > > > > To help make those call sites terser and less cumbersome, this > > patch adds a new family of thread flag manipulators > > > > update*_thread_flag([...,] flag, cond) > > > > which do the equivalent of: > > > > if (cond) > > set*_thread_flag([...,] flag); > > else > > clear*_thread_flag([...,] flag); > > > > Signed-off-by: Dave Martin <dave.mar...@arm.com> > > Acked-by: Steven Rostedt (VMware) <rost...@goodmis.org> > > Acked-by: Marc Zyngier <marc.zyng...@arm.com> > > Acked-by: Catalin Marinas <catalin.mari...@arm.com> > > Cc: Ingo Molnar <mi...@redhat.com> > > Cc: Peter Zijlstra <pet...@infradead.org> > > Cc: Oleg Nesterov <o...@redhat.com> > > --- > > include/linux/sched.h | 6 ++++++ > > include/linux/thread_info.h | 11 +++++++++++ > > 2 files changed, 17 insertions(+) > >
[...] > > diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h > > index cf2862b..8d8821b 100644 > > --- a/include/linux/thread_info.h > > +++ b/include/linux/thread_info.h > > @@ -60,6 +60,15 @@ static inline void clear_ti_thread_flag(struct > > thread_info *ti, int flag) > > clear_bit(flag, (unsigned long *)&ti->flags); > > } > > > > +static inline void update_ti_thread_flag(struct thread_info *ti, int flag, > > + bool value) > > +{ > > + if (value) > > + set_ti_thread_flag(ti, flag); > > + else > > + clear_ti_thread_flag(ti, flag); > > +} > > + > > value does seem a bit of vanilla non-informative name for a condition > flag but whatever: > > Reviewed-by: Alex Bennée <alex.ben...@linaro.org> I guess, though I couldn't some up with an obviously better name. I support "condition" would have worked, but it's more verbose. Thanks for the review ---Dave _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm