On 28/03/2019 16:48, Dave Martin wrote: > On Thu, Mar 28, 2019 at 02:29:23PM +0000, Julien Thierry wrote: >> >> >> On 28/03/2019 12:27, Dave Martin wrote: >>> On Wed, Mar 27, 2019 at 03:21:02PM +0000, Julien Thierry wrote: >>>> >>>> >>>> On 27/03/2019 10:33, Dave Martin wrote: > > [...] > >>>>> return slices; >>>>> } >>>>> >>>>> This may be clearer, but felt a bit like overkill... >>>>> >>>>> Thoughts? >>>> >>>> Seems a bit overkill yes... I was more thinking of a define and the >>>> person in charge of adding the slice support would just need to look for >>>> references to that define to know (some of) the places that would need >>>> rework/review. >>>> >>>> So, unless someone else thinks it's good to introduce it right now you >>>> can ignore that. >>> >>> OK, how about the following? This keeps things minimal, but should help >>> future maintainers know that something may need updating here in the >>> future. >>> >> >> Yes, I think this looks good. > > OK, are you happy for me to keep your Reviewed-by with that change? > Yes, please do! Thanks, -- Julien Thierry _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
- [PATCH v6 04/27] KVM: arm64: Refactor kvm_arm_num_regs() fo... Dave Martin
- [PATCH v6 16/27] KVM: arm64: Factor out core register ID en... Dave Martin
- Re: [PATCH v6 16/27] KVM: arm64: Factor out core regis... Julien Thierry
- [PATCH v6 19/27] KVM: arm64: Enumerate SVE register indices... Dave Martin
- Re: [PATCH v6 19/27] KVM: arm64: Enumerate SVE registe... Julien Thierry
- Re: [PATCH v6 19/27] KVM: arm64: Enumerate SVE reg... Dave Martin
- Re: [PATCH v6 19/27] KVM: arm64: Enumerate SVE... Julien Thierry
- Re: [PATCH v6 19/27] KVM: arm64: Enumerate... Dave Martin
- Re: [PATCH v6 19/27] KVM: arm64: Enum... Julien Thierry
- Re: [PATCH v6 19/27] KVM: arm64: Enum... Dave Martin
- Re: [PATCH v6 19/27] KVM: arm64: Enum... Julien Thierry
- [PATCH v6 20/27] arm64/sve: In-kernel vector length availab... Dave Martin
- [PATCH v6 17/27] KVM: arm64: Reject ioctl access to FPSIMD ... Dave Martin
- Re: [PATCH v6 17/27] KVM: arm64: Reject ioctl access t... Julien Thierry
- [PATCH v6 13/27] KVM: arm64/sve: Context switch the SVE reg... Dave Martin
- Re: [PATCH v6 13/27] KVM: arm64/sve: Context switch th... Julien Thierry
- [PATCH v6 18/27] KVM: arm64/sve: Add SVE support to registe... Dave Martin
- Re: [PATCH v6 18/27] KVM: arm64/sve: Add SVE support t... Julien Thierry
- [PATCH v6 12/27] KVM: arm64/sve: System register context sw... Dave Martin
- Re: [PATCH v6 12/27] KVM: arm64/sve: System register c... Julien Thierry
- [PATCH v6 21/27] KVM: arm/arm64: Add hook for arch-specific... Dave Martin