As promised, let's move SPSR_EL1 to the VNCR page.

Signed-off-by: Marc Zyngier <m...@kernel.org>
---
 arch/arm64/include/asm/kvm_emulate.h | 4 ++--
 arch/arm64/include/asm/kvm_host.h    | 2 +-
 arch/arm64/kvm/guest.c               | 2 +-
 arch/arm64/kvm/hyp/sysreg-sr.c       | 4 ++--
 arch/arm64/kvm/regmap.c              | 4 ++--
 arch/arm64/kvm/sys_regs.c            | 4 ++--
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/include/asm/kvm_emulate.h 
b/arch/arm64/include/asm/kvm_emulate.h
index eed8bd48e60c..6df684e1790e 100644
--- a/arch/arm64/include/asm/kvm_emulate.h
+++ b/arch/arm64/include/asm/kvm_emulate.h
@@ -327,7 +327,7 @@ static inline unsigned long vcpu_read_spsr(const struct 
kvm_vcpu *vcpu)
        if (vcpu->arch.sysregs_loaded_on_cpu)
                return read_sysreg_el1(SYS_SPSR);
        else
-               return vcpu->arch.ctxt.spsr_el1;
+               return __vcpu_sys_reg(vcpu, SPSR_EL1);
 }
 
 static inline void vcpu_write_spsr(struct kvm_vcpu *vcpu, unsigned long v)
@@ -345,7 +345,7 @@ static inline void vcpu_write_spsr(struct kvm_vcpu *vcpu, 
unsigned long v)
        if (vcpu->arch.sysregs_loaded_on_cpu)
                write_sysreg_el1(v, SYS_SPSR);
        else
-               vcpu->arch.ctxt.spsr_el1 = v;
+               __vcpu_sys_reg(vcpu, SPSR_EL1) = v;
 }
 
 /*
diff --git a/arch/arm64/include/asm/kvm_host.h 
b/arch/arm64/include/asm/kvm_host.h
index 111597123c17..657c2c5d1a39 100644
--- a/arch/arm64/include/asm/kvm_host.h
+++ b/arch/arm64/include/asm/kvm_host.h
@@ -266,6 +266,7 @@ enum vcpu_sysreg {
        VNCR(MDSCR_EL1),/* Monitor Debug System Control Register */
        VNCR(ELR_EL1),
        VNCR(SP_EL1),
+       VNCR(SPSR_EL1),
        VNCR(VPIDR_EL2),/* Virtualization Processor ID Register */
        VNCR(VMPIDR_EL2),/* Virtualization Multiprocessor ID Register */
        VNCR(HCR_EL2),  /* Hypervisor Configuration Register */
@@ -336,7 +337,6 @@ enum vcpu_sysreg {
 struct kvm_cpu_context {
        struct user_pt_regs regs;       /* sp = sp_el0 */
 
-       u64     spsr_el1;               /* aka spsr_svc */
        u64     spsr_abt;
        u64     spsr_und;
        u64     spsr_irq;
diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c
index 9710fe55c5dd..e295368a13f2 100644
--- a/arch/arm64/kvm/guest.c
+++ b/arch/arm64/kvm/guest.c
@@ -131,7 +131,7 @@ static void *core_reg_addr(struct kvm_vcpu *vcpu, const 
struct kvm_one_reg *reg)
                return __vcpu_elr_el1(vcpu);
 
        case KVM_REG_ARM_CORE_REG(spsr[KVM_SPSR_EL1]):
-               return &vcpu->arch.ctxt.spsr_el1;
+               return __ctxt_sys_reg(&vcpu->arch.ctxt, SPSR_EL1);
 
        case KVM_REG_ARM_CORE_REG(spsr[KVM_SPSR_ABT]):
                return &vcpu->arch.ctxt.spsr_abt;
diff --git a/arch/arm64/kvm/hyp/sysreg-sr.c b/arch/arm64/kvm/hyp/sysreg-sr.c
index b009afd87322..eaf78e9b3238 100644
--- a/arch/arm64/kvm/hyp/sysreg-sr.c
+++ b/arch/arm64/kvm/hyp/sysreg-sr.c
@@ -60,7 +60,7 @@ static void __hyp_text __sysreg_save_vel1_state(struct 
kvm_cpu_context *ctxt)
 
        ctxt_sys_reg(ctxt, SP_EL1)      = read_sysreg(sp_el1);
        ctxt_sys_reg(ctxt, ELR_EL1)     = read_sysreg_el1(SYS_ELR);
-       ctxt->spsr_el1                  = read_sysreg_el1(SYS_SPSR);
+       ctxt_sys_reg(ctxt, SPSR_EL1)    = read_sysreg_el1(SYS_SPSR);
 }
 
 static void __sysreg_save_vel2_state(struct kvm_cpu_context *ctxt)
@@ -325,7 +325,7 @@ static void __hyp_text __sysreg_restore_vel1_state(struct 
kvm_cpu_context *ctxt)
 
        write_sysreg(ctxt_sys_reg(ctxt, SP_EL1),        sp_el1);
        write_sysreg_el1(ctxt_sys_reg(ctxt, ELR_EL1),   SYS_ELR);
-       write_sysreg_el1(ctxt->spsr_el1,                SYS_SPSR);
+       write_sysreg_el1(ctxt_sys_reg(ctxt, SPSR_EL1),  SYS_SPSR);
 }
 
 static void __hyp_text __sysreg_restore_el1_state(struct kvm_cpu_context *ctxt)
diff --git a/arch/arm64/kvm/regmap.c b/arch/arm64/kvm/regmap.c
index 97c110810527..accc1d5fba61 100644
--- a/arch/arm64/kvm/regmap.c
+++ b/arch/arm64/kvm/regmap.c
@@ -150,7 +150,7 @@ unsigned long vcpu_read_spsr32(const struct kvm_vcpu *vcpu)
        if (!vcpu->arch.sysregs_loaded_on_cpu) {
                switch (spsr_idx) {
                case KVM_SPSR_SVC:
-                       return vcpu->arch.ctxt.spsr_el1;
+                       return __vcpu_sys_reg(vcpu, SPSR_EL1);
                case KVM_SPSR_ABT:
                        return vcpu->arch.ctxt.spsr_abt;
                case KVM_SPSR_UND:
@@ -185,7 +185,7 @@ void vcpu_write_spsr32(struct kvm_vcpu *vcpu, unsigned long 
v)
        if (!vcpu->arch.sysregs_loaded_on_cpu) {
                switch (spsr_idx) {
                case KVM_SPSR_SVC:
-                       vcpu->arch.ctxt.spsr_el1 = v;
+                       __vcpu_sys_reg(vcpu, SPSR_EL1) = v;
                        break;
                case KVM_SPSR_ABT:
                        vcpu->arch.ctxt.spsr_abt = v;
diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
index 0d3500a11c50..f20f5975633f 100644
--- a/arch/arm64/kvm/sys_regs.c
+++ b/arch/arm64/kvm/sys_regs.c
@@ -1850,9 +1850,9 @@ static bool access_spsr(struct kvm_vcpu *vcpu,
                return false;
 
        if (p->is_write)
-               vcpu->arch.ctxt.spsr_el1 = p->regval;
+               __vcpu_sys_reg(vcpu, SPSR_EL1) = p->regval;
        else
-               p->regval = vcpu->arch.ctxt.spsr_el1;
+               p->regval = __vcpu_sys_reg(vcpu, SPSR_EL1);
 
        return true;
 }
-- 
2.20.1

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Reply via email to