[
https://issues.apache.org/jira/browse/LABS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629732#action_12629732
]
Thorsten Scherler commented on LABS-141:
----------------------------------------
Thanks for the patch, Ryan.
I reviewed the patch and the part of the refactoring the link to task is good
as gold.
Not sure but it seems there are some unrelated changes in the patch.
I am referring to
Index: src/core/java/org/apache/droids/handle/Save.java. The suggested change
can create two times a new File() where before only once. Are there any
special reason for your change?
The other is src/core/java/org/apache/droids/DefaultWorker.java.
+ e.printStackTrace();
Core.threadMessage(e.getMessage());
The e.printST will provoke that you throw 2 times the exception (once the stack
and the other only the message). I would prefer that we throw the stack in the
Core.threadMessage. WDYT?
Last but not least src/core/java/org/apache/droids/parse/html/HtmlParser.java
is a problem you mentioned in an other mail.
Feel free to apply the changes to
Index: src/core/java/org/apache/droids/queue/Simple.java
Index: src/core/java/org/apache/droids/queue/QueueBean.java
> QueueBean and simple queue are tied to the "Link" Task
> ------------------------------------------------------
>
> Key: LABS-141
> URL: https://issues.apache.org/jira/browse/LABS-141
> Project: Labs
> Issue Type: Improvement
> Components: Droids
> Reporter: Ryan McKinley
> Attachments: LABS-141-droids-simple-queue.patch
>
>
> Currently the QueueBean and Simple queue unnecessarly are linked to the Link
> task type -- that means they can't be used for other Task types!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
