On Thu, 2008-10-09 at 16:47 +0000, [EMAIL PROTECTED] wrote:
> Author: ryan
> Date: Thu Oct  9 09:47:05 2008
> New Revision: 703206
> 
> URL: http://svn.apache.org/viewvc?rev=703206&view=rev
> Log:
> LABS-189 -- adding wicket component stub.  Note the scripts don't work to 
> compile it (i'm compiling with eclipse for now.  Mostly putting this here as 
> a concrete layout example

Did you used droids seed? I think so but there are some differences. 

A side note some of you files do not belong in this commit/rep. Please
make sure in the future to exclude them before doing the commit. TIA.

Added:
>     labs/droids/branch/LABS-144/depot/wicket/
>     labs/droids/branch/LABS-144/depot/wicket/.classpath
>     labs/droids/branch/LABS-144/depot/wicket/.project

both files are normally user specific, if so they should not be
committed. I saw some 

+       <classpathentry combineaccessrules="false" kind="src"
path="/Droids"/>
+       <classpathentry kind="lib"
path="/Users/ryan/Documents/workspace/APACHE/droids/lib/slf4j-log4j12-1.5.3.jar"/>

That will soon lead to a constant "commit war" since everyone will needs
to change this properties for her environment. Maybe we should provide
an ant task that generates this files.

...
>     labs/droids/branch/LABS-144/depot/wicket/lib/cglib-2.1_3.jar   (with 
> props)
[more jars]

We need to make sure that all our jars that we distribute have their
license attached, this will help the IP clearance in the incubator.

Please keep keep this in mind. 

>     labs/droids/branch/LABS-144/depot/wicket/log.txt

This file definitely does not belong in the rep. 

>     labs/droids/branch/LABS-144/depot/wicket/src/
[...]

>     labs/droids/branch/LABS-144/depot/wicket/src/webapp/WEB-INF/web.xml

The other thing is the naming "wicket" as I understand the commit after
a quick look it is about starting droids, or?

Can you clarify what the component does?

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to