Begin forwarded message:
From: Brenda Wallace <[email protected]>
Date: 17 August 2009 11:01:17
To: Michael Fötsch <[email protected]>
Subject: Re: [Laconica-dev] Laconica inside an intranet
On 17/08/2009, at 6:34, Michael Fötsch <[email protected]> wrote:
Hi,
I'm working on a few patches to make Laconica run better inside an
intranet. Some issues are with http proxies, some with Internet
Explorer. I'd like to discuss the patches and/or the remaining issues
with you.
(I'm working with the 0.8.0 tarball, because that's what I'm
upgrading
to at my company, but I'm following the changes on the 0.9.x dev
branch
as well.)
1. Validate::email(address, true): This appears in various places
(registration, email settings, invite), but doesn't work if the http
proxy blocks traffic to the internet. I *could* send emails to
[email protected], but I won't get that far, because
"Validate::email(true)" says company.com is not a valid domain.
Patch: I'd like to replace all "Validate::email(address, true)" with
common_validate_email() in util.php and make it configurable in
config.php whether to use "Validate::email" with or without a
domain check.
I have also hit my head against this validation, on servers with no
DNS. I like your proposed fix very much.
While you're there, laconica show a "database error" message if it's
unable to send email. If you spot this and fix that would be great.
It really needs a better error message as a minimum.
2. Notices containing URLs: Both common_shorten_url() and
common_shorten_links() try to contact the outside world but run
into the
http proxy, which causes massive delays when adding new notices.
Patch: Make it configurable to run without shortening and
File_redirection.
(What I'm not sure I understand from the code: What does
File_redirection::makeShort() do in the first place?)
3. Valid URLs are rejected by the regular expressions:
"http://someintranetserver/xy.html"; doesn't pass, neither does
"http://10.129.12.34";
Patch: Be less strict in the regexes (configurable?)
4. Internet Explorer problem: When sending new notices with
attachments
(but not without attachments!), IE rejects the Ajax response sent by
Laconica, so sending the notice never succeeds (busy animation just
stays on the Send button forever). Maybe this is an IE bug, but in
any
case, Laconica's response is not valid XHTML according to the w3c
validator (the "<li>" tag seems to require a surrounding "<ol>" or
"<ul>" tag).
Patch: I have no idea where to start. I have a few error messages and
logs though, if anyone would like to help me debug this.
I'd really appreciate any feedback that you can give.
Kind Regards,
M.F.
_______________________________________________
Laconica-dev mailing list
[email protected]
http://mail.laconi.ca/mailman/listinfo/laconica-dev
_______________________________________________
Laconica-dev mailing list
[email protected]
http://mail.laconi.ca/mailman/listinfo/laconica-dev
