No, no. It was just faster do submit with the fix than to tease the fix out of the change, check that in, and reapply the change. I hope you don't mind. But a review of what I checked in would be nice -- I'm sure there are further improvements there.
On Apr 14, 2006, at 9:40 AM, P T Withington wrote: > Ok, I'll review what you submitted. Sorry for not responding > faster, I have been bogged down on my debugger stuff... > > On 2006-04-14, at 12:29 EDT, Jim Grandy wrote: > >> I went ahead and submitted an amended version of this to fix the >> nightly build breakage with the documentation. >> >> jim >> >> On Apr 13, 2006, at 1:40 PM, Jim Grandy wrote: >> >>> Change 41455 by [EMAIL PROTECTED] on 2006/04/13 13:34:58 *pending* >>> >>> Summary:Modify name for trait interstitials, refactor code so >>> more trait-specific code lives in LzTrait.as, add some useful >>> attributes to LzTrait instances and interstitials. >>> >>> Technical Reviewer: ptw (pending) >>> QA Reviewer: mdavis (pending) >>> Doc Reviewer: n/a >>> >>> Details:Trait interstitials are currently implementated as classes >>> that implement traits within a particular class chain. The class >>> name used to be very generic, but now it has the trait name built >>> into it. I didn't add the superclass' name to the trait name, as >>> was >>> suggested, because doing that right is a bit complicated if you >>> want >>> to avoid very long class names (e.g. in the case of multiple traits >>> chained between a class and its superclass). >>> >>> Tests:test/traits.lzx >>> >>> Affected files ... >>> >>> ... //depot/lps-dev/WEB-INF/lps/lfc/core/LzTrait.as#2 edit >>> ... //depot/lps-dev/WEB-INF/lps/lfc/core/UserClass.as#6 edit >>> >>> >>> <changeset-41455.zip> >>> _______________________________________________ >>> Laszlo-dev mailing list >>> [email protected] >>> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev >> > _______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
