...and more trouble. I tried this on a branch in subversion, and ran  
into more problems. The ant rules look ok -- they are not linked to  
VENDOR_ROOT and all is well there. However, there are four XSLT  
template files with relative paths from the source dir back into the  
tools dir. Lines like this:

   <xsl:import href="../../../../tools/docbook-xsl-1.65.1/html/ 
chunk.xsl"/>

One option would be to revive that idea we discussed to branch the  
vendor files into the source tree, so we'd have specific files and  
subdirectories branched from /vendor into /openlaszlo/trunk/vendor  
(and also into the branches and tags).

Another avenue would be to figure out how to pass VENDOR_ROOT in to  
the XSLT templates as parameters. I googled that a bit, and it looks  
possible, but I'm beginning to wonder now whether we wouldn't be  
better off with self-contained build environments.

(For the benefit of laszlo-dev, these changes are to make OpenLaszlo  
build in the new subversion repository. We have the following  
structure now:

/openlaszlo/trunk
/openlaszlo/branches/...
/tools
/vendor

Where /vendor has external tools and code libraries, and /tools has  
cross-project scripts and tools. The subversion book recommends  
branching from /vendor into project source trees, and I'm starting to  
think this is the right approach for us too.)


On Apr 16, 2006, at 3:45 PM, Jim Grandy wrote:

> Hold on reviewing this. I think it should be VENDOR_ROOT, not  
> TOOLS_ROOT, that we should be defining. I'll resubmit.
>
> On Apr 16, 2006, at 2:53 PM, Jim Grandy wrote:
>
>> Change 41553 by [EMAIL PROTECTED] on 2006/04/16 14:48:34 *pending*
>>
>>      Summary:Doc build shouldn't depend on tools dir being a sibling  
>> of LPS_HOME.
>>      
>>      Bugs Fixed:LPP-1970
>>      
>>      Technical Reviewer: ben (pending)
>>      QA Reviewer: jsundman (pending)
>>      Doc Reviewer: n/a
>>      
>>      Details:Declare TOOLS_ROOT in build-op.xml. For now, substitute
>>      ${LPS_HOME}/.. as default value if TOOLS_ROOT is not defined. When
>>      we convert to subversion, this default value should be removed and
>>      an error signaled if TOOLS_ROOT is not declared in the shell  
>> environment.
>>      
>>      Tests:Ran 'ant doc' successfully.
>>
>> Affected files ...
>>
>> ... //depot/lps-dev/build-tools/build-opt.xml#3 edit
>> ... //depot/lps-dev/docs/src/build-dbk.xml#2 edit
>> ... //depot/lps-dev/docs/src/build.xml#9 edit
>>
>>
>> <changeset-41553.zip>
>> _______________________________________________
>> Laszlo-dev mailing list
>> [email protected]
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
>

_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev

Reply via email to