Phil, Task 1 After you fix the 7 of 25, please send the changeset out for review (Tucker has volunteered - thanks, Tucker!).
Task 2 Then, please use the DeclareEvent pattern, and remove the if's as you no longer have to check for null. Please do this in the same set of files you are currently working with, and then send that out for review (Henry has volunteered to review this next changeset - thanks, Henry!) Task 3 Once this is taken care of, then don't proceed with smokecheck.lzx. Instead, please go back to the animator files (lzAnimator, lzAnimatorGroup), and finish their unit tests and merge them. There are some old unit tests for these in the test/lfc/animators dir that may or may not be useful. Also, there is another file test/lfc/ testanim.lzx, which may be useful. Certainly these unit tests are old enough that they won't run in the unit test framework that you are writing the current ones to support. Thanks, Amy On May 15, 2006, at 10:30 PM, Philip Romanik wrote: > The change only affects 7 of the 25 files I have checked out. I'll > wait > until morning before I make the changes. DeclareEvent is used many > more > times in the DHTML code than I'll make to the Flash code. Like you > said, > the issue is already out there and can be revisited separately. > > Phil > > > > >> Yes it's supported in Flash, it's in the new common file core/ >> LzDefs.lzs >> >> I think you should go ahead and use this idiom for these >> uninitializied >> events. >> We can always change the semantics of it later, but it will be >> best to >> have the same >> approach used everywhere. > > _______________________________________________ > Laszlo-dev mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-dev _______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
