Hi Tucker,

Thanks for the detailed answers. I applied your changes and learned a 
couple of things. See below. I'll send a separate email regarding #6.

Thanks!

Phil



> >  2. Same question as the previous item.
> >   Current:
> >       this.setClassEvents( arguments.callee );
> >
> >   New:
> >       if ('setClassEvents' in this)
> >             this.setClassEvents( arguments.callee );
>
>This should not be giving a warning, since
>LzNode.prototype.setClassEvents is defined.  If it is giving a
>warning, perhaps you can figure out why by putting in some debug
>statements:
>
>        if (! ('setClassEvents' in this)) {
>          Debug.debug('No setClassEvents in %w', this);
>        }
>
>And then inspect the object to figure out how it could not have a
>setClassEvents.

setClassEvents is defined in UserClass.as and hooked up when LzMakeClass is 
called. There is a conditional in LzMakeClass so it appears that 
setClassEvents is not wired up in all cases.




> > 3. I'm not sure about this one; maybe my notes are wrong.
> > 'this.parent' is
> > initialized to null, but I get an error if I don't use 'in'
> >
> >   Current:
> >       if ( this.parent.__LZpreventSubInit ){
> >
> >   New:
> >       if ( ('parent' in this) && this.parent.__LZpreventSubInit ){
>
>Strange.  Again, perhaps a debug statement would help figure out what
>'this' is and how it could not have a .parent field.

I used your debugging technique and found one instance where parent was not 
set. parent is set in the constructor so it can be null. I found a comment 
in LzNode.as that confirms this. I'll leave the conditional in the code.


_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev

Reply via email to