I now think that this was a type-oh for:
this.setChildNodes([]);
(compare the else branch.)
I'd call the setter, just incase there is someone listening for
onchildnodes.
On 2006-05-18, at 17:11 EDT, Philip Romanik wrote:
> I'm attaching a change I'm planning to make to LzDataElement.as to
> cleanup
> an error. I'm also attaching Tucker's comment on the change. Does
> anybody
> know if the intent of this line of code,
>
> this.childNodes([]);
>
> is anything other than initializing childNodes? I'm working on the
> lps-legals branch.
>
> Thanks!
>
> Phil
>
>
>>> LzDataElement.as
>>> ----------------
>>>
>>> 6. Is this right? Here's the new code (with the existing code as a
>>> comment
>>> if (children == null) {
>>> this.childNodes = []; // <-- Was: this.childNodes
>>> ([]);
>>> } else {
>>> this.setChildNodes( children );
>>> }
>>
>> Oh, I saw that in the review and forgot to ask. That clearly looks
>> like a brain-oh on someone's part. You might ask Adam, Henry and Max
>> directly (they are more familiar with the data code) what they think,
>> but it sure looks like you are right to me.
>
> _______________________________________________
> Laszlo-dev mailing list
> [email protected]
> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
