On 2006-05-04, at 21:19 EDT, Benjamin Shine wrote:
>
> At long last, here are the svn versions of the p4-bash scripts.
> Please review and comment... this is one of the last steps between
> us and subversion!
My comments [after finally trying this out!]
1) IWBNI the change description temp file could have a .txt extension
so my editor (emacs) would open it in text mode.
2) The review-mail script is working a little by luck. It composes
the subject of the email from the first two lines of the change
description. This used to be the change # and summary line, now it
is the summary line and the technical reviewer. It's ok that way,
but someone who comes along later might wonder why we elide the word
'Change' from any summary...
2a) Maybe we should have something like a change # line, perhaps
composed from the date/time/user?
3) This is a better way to invoke mail on OS X that won't blow up for
long URL's (I reported the URL bug to Apple, but I don't think they
have fixed it.)
osascript -e 'tell application "Mail"' -e "mailto(\"${mailto}
\")" -e 'activate' -e 'end tell'
_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
