Bad form I understand. Seems like a weak justification for causing a build break, though -- especially since this was an LZX file and application developers won't in general keep tabs out of their source files. Are we doing ourselves a service by only building and testing against tab-free source files?
On Jun 19, 2006, at 5:45 PM, P T Withington wrote: > It's considered bad form to have 'non-canonical' whitespace in your > repository. It creates diffs where there are none. So, basically, > for the same reason we don't want DOS line endings in the repository. > > If I ran the zoo, I would complain about non-empty blank lines and > whitespace at the end of lines too. > > Most editors have an auto-expand-tabs mode, so this should not be > hard to obey. Some editors even flag stray whitespace. > > On 2006-06-19, at 19:25 EDT, Jim Grandy wrote: > >> We either need a pre-commit hook to check for hard tabs, or we >> need to remove this requirement. Why is it in place, again? >> >>> [exec] There are hard tabs in ./lps-3.3.x/lps/components/ >>> incubator/lwzCalendar/lwzEncalendar.lzx >> >> jim >> >> Begin forwarded message: >> >>> From: [EMAIL PROTECTED] >>> Date: June 19, 2006 4:11:44 PM PDT >>> To: [EMAIL PROTECTED] >>> Subject: [Laszlo-builds] FAILURE for 1073-openlaszlo-trunk on >>> linux-builder.corp.laszlosystems.com >>> >>> FAILURE: build failed for 1073-openlaszlo-trunk at Mon Jun 19 >>> 16:11:43 PDT 2006 attaching /home/svnbuild/logs/tail-1073-trunk- >>> nightly.log_______________________________________________ >>> Laszlo-builds mailing list >>> [EMAIL PROTECTED] >>> http://www.openlaszlo.org/mailman/listinfo/laszlo-builds >> >> _______________________________________________ >> Laszlo-dev mailing list >> [email protected] >> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev > _______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
