Hi Henry, I'd prefer to see the "validate" attribute default to true to match current behavior. I think that the spurious warning is triggered infrequently enough (and Google is good enough, provided we document this in the release notes) that we are not causing too much inconvenience for those who hit it. I'd prefer to leave the validator warnings turned on for most users so they can benefit. If you'd like to add a build.properties flag to match so folks can turn the validator off completely, that's fine.
Another note: if you look at the difffile in the change set, you'll notice that the files have their executable bit set. Please change that with "svn propdel svn:executable" for each file. Otherwise, approved! jim On Jul 27, 2006, at 7:38 PM, Henry Minsky wrote: > [updated change message to point to JIRA bug number] > > Change change.Mdinj2316.txt by [EMAIL PROTECTED] /home/hqm/src/svn/ > openlaszlo/branches/legals/ on 2006-07-27 18:00:02 EDT > > Summary: set 'validate' flag from root element (canvas) attributes > > New Features: > > Bugs Fixed: lpp-2427 > > Technical Reviewer: jgrandy (pending) > QA Reviewer: mdavis (pending) > Doc Reviewer: jrs (pending) > > > Documentation: > > Release Notes: > > Details: > > The root element of the file being compiled will accept the > "validate" attribute as a boolean > flag, defaulting to false. > > Tests: > > test/compiler_errors/validate-true.lzx set validate via app > file canvas attribute > test/compiler_errors/validate-false.lzx > test/compiler_errors/validate.lzx default value of > validate=false > > > > > > Files: > A test/compiler_errors/validate.lzx > A test/compiler_errors/validate- true.lzx > A test/compiler_errors/validate-false.lzx > M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java > > _______________________________________________ > Laszlo-dev mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-dev _______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
