Not approved yet.
It looks like you may have a conflict with some work Henry is doing
in LzDataSet, LzDatasource, LZHTTPDatasource. Could you update them
and merge so I can review?
---
For the other files in this change, approved, if you will address the
following issues. (I don't need to re-review those files, so maybe
you can just split the change.)
* In LzDataText:
I was mistaken about this line:
LzDataText.prototype.setAttribute = LzNode.prototype.setAttribute;
being cruft. The line following it, which defines a setters property
is useless without this. The comment above the setters applies to
both these statements, perhaps you should move the comment above the
definition of setAttribute. (The fact that deleting this line did
not break a test is disturbing.)
`setters` needs to be a var -- remember LzDataNode (despite its name)
does not inherit from Node. What is going on here is that we are
cheesily replicating the setters/setAttribute behavior from Node on
DataNode. Hence my comment that that behavior really should be a trait.
* In LzDatapath:
Why is _dpevents not a var?
You should not need to say `prototype.` when defining
getXPath.dependencies, or xPathQuery.dependencies.
This:
var pathSymbols= { };
pathSymbols[ "/" ] = 1;
pathSymbols[ ".." ] = 2;
pathSymbols[ "*" ] = 3;
pathSymbols[ "." ] = 4;
can be more compactly written as:
var pathSymbols = {'/': 1, '..': 2, '*': 3, '.': 4};
* In LzReplicationManager:
Line 169: I'm not sure __LzEmptyFunction will be in scope until
LPP-2414 is fixed. I think you will need to keep it as
LzReplicationManager.__LZEmptyFunction.
---
Everything else looks great.
On 2006-07-27, at 09:16 EDT, Philip Romanik wrote:
> (The changes are relative to lps/lfc/data)
>
>
> Change change.vsuqQ5488.txt by [EMAIL PROTECTED] /tmp/ on 2006-07-26
> 20:29:28 EDT
>
> Summary: Update data to use new class system.
>
> New Features:
>
> Bugs Fixed: LPP-2388
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> Tests: lzpix
>
> Files:
> M LzReplicationManager.lzs
> M LzDatapointer.lzs
> M LzDataText.lzs
> M LzDataset.lzs
> M LzDatapath.lzs
> M LzDatasource.lzs
> M LzHTTPDatasource.lzs
> M LzParsedPath.lzs
> M LzParam.lzs
> <patch.Philip.5348.tgz>
_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
