Not approved. You did not send a changeset, so I can only speculate on what your actual change is from the change description, but the whole point of the build id is to help the developer and QA know which version they are running. It seems you are proposing to make the default be to set the build id to a constant string, which makes it pointless.
I feel it is very important that the developer builds and the nightly builds have the correct build id. What is wrong with just telling the user to update their svn client? On 2006-09-15, at 15:12 EDT, Benjamin Shine wrote: > Change change.XXXXXXXXX.kFVn10CF.txt by [EMAIL PROTECTED] /Users/ > ben/src/svn/openlaszlo/branches/legals/ on 2006-09-15 11:59:15 PDT > > Summary: Do not query svn for version info unless explicitly requested > > New Features: > > Bugs Fixed: LPP-2635 Build system fails if svn client > 1.3.1 is > not present > > Technical Reviewer: ptw > QA Reviewer: mamye > Doc Reviewer: none > > Documentation: > By default, the build system will not try to query subversion. This > means it won't fail > if subversion is not present. If you want the compiled in version > info to come from > svn, pass in -Dsvn.query=true, and make sure that svn 1.3.1 or > later is present. > If you want to explicitly specify a build id, pass in - > Dbuild.id="my_special_build_id" > > This addresses problems we've had building on machines with no > subversion client or > pre-1.3.1 versions of subversion client. > > Release Notes: > > Details: > > > Tests: > > Files: > M WEB-INF/lps/server/build.xml > > <change.XXXXXXXXX.kFVn10CF.txt> _______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
