Sorry I missed your email. I looked for it, but didn't see it. My high-level point here is that the checkin says, "Fix explore- nav.lzx in dhtml", but explore-nav.lzx doesn't even compile in DHTML. And there's obvious breakage in the Flash version of explore-nav.lzx. So perhaps I can request that you revoke your approval :-)
jim On Sep 25, 2006, at 11:02 AM, P T Withington wrote: > On 2006-09-25, at 13:24 EDT, Jim Grandy wrote: > >> I haven't seen a review or checkin for this. > > I approved it on the 21st with a request that Max file a bug > regarding layout class being the string 'null': > > Begin forwarded message: >> From: P T Withington <[EMAIL PROTECTED]> >> Date: 21 September 2006 18:11:48 EDT >> To: Max Carlson <[EMAIL PROTECTED]> >> Cc: [EMAIL PROTECTED], [EMAIL PROTECTED], laszlo- >> [EMAIL PROTECTED] >> Subject: Re: For Review: Change change.SV2sD4VYi.txt Summary: Fix >> explore-nav.lzx in dhtml. >> >> Approved, if you will file a bug (and add a comment referencing >> the bug) regarding layout class being the string 'null'. I >> suspect a bug in the tag compiler is the root cause. If there >> were a small test case that we could 'lzc --script' we could see >> if that were so. What was the source that was tickling that bug? >> Can we boil it down to a test case? > >> I did just try applying it to a tot legals tree, and there are >> some new visual glitches apparent in the navbar in flash. >> >> I also get two "DHTML does not support importing fonts" compile >> errors in DHTML, with no navbar appearing. > > AFAIK DHTML does not support importing fonts, so, you can't do > that. The source needs to be changed. I don't think there is any > plan to address this other than to issue a warning. > >> http://localhost:8080/legals/laszlo-explorer/explore-nav.lzx? >> lzr=dhtml >> >> It's important we get this in to the Legals build today or >> tomorrow if we are going to stabilize in time for next week. >> >> jim >> >> Begin forwarded message: >> >>> From: Max Carlson <[EMAIL PROTECTED]> >>> Date: September 19, 2006 11:42:49 PM PDT >>> To: [EMAIL PROTECTED], [EMAIL PROTECTED] >>> Cc: [email protected] >>> Subject: [Laszlo-dev] For Review: Change change.SV2sD4VYi.txt >>> Summary: Fix explore-nav.lzx in dhtml. >>> >>> Change change.SV2sD4VYi.txt by [EMAIL PROTECTED] >>> computer.local /Users/maxcarlson/openlaszlo/legals/ on 2006-09-19 >>> 23:31:48 PDT >>> >>> Summary: Fix explore-nav.lzx in dhtml. >>> >>> New Features: >>> >>> Bugs Fixed: >>> >>> Technical Reviewer: ptw >>> QA Reviewer: promanik >>> Doc Reviewer: (pending) >>> >>> Documentation: >>> >>> Release Notes: >>> >>> Details: I'm not sure all of these changes should be necessary, >>> in particular the test for this.p in LzDatapointer.lzs - >>> shouldn't this.p always be set? Also, it's strange that I have >>> to test for the string version of 'null' in LaszloView.lzs. The >>> LzDatapointer and LzNode changes feel like the problems I was >>> seeing with data after r1857. Please investigate! >>> >>> >>> Tests: http://localhost:8080/legals/laszlo-explorer/explore- >>> nav.lzx?lzr=dhtml runs! >>> >>> Files: >>> M WEB-INF/lps/lfc/core/LzNode.lzs >>> M WEB-INF/lps/lfc/views/LaszloView.lzs >>> M WEB-INF/lps/lfc/data/LzDatapointer.lzs >>> >>> _______________________________________________ >>> Laszlo-dev mailing list >>> [email protected] >>> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev >> > _______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
