Approved with the following changes: 1) In vacation-survey.html: a) This needs a DOCTYPE to not trigger quirks mode (which will break DHTML).
2) In vacation-survey, weather, contacts, image-loading: a) Not clear what the width and height attributes on the appcontainer div are for, at the very least they won't validate. 3) In quick-index.xslt a) It looks like there is some bogus character in the copyright comment 4) In contactlist.html a) The comment lies about the name of the file, why not just remove these. General comments: 1) It would be great if QA ensured that: a) The web pages all passed the [w3c validator](http:// validator.w3.org/) b) The web pages do not trigger 'quirks mode' (Firefox gives you a nifty check mark). 2) It seems like the demo/example html pages are almost templates with just the demo and the descriptive text inside. Perhaps there is a way to do that with our good friend XSLT and save the code duplication? Nits: 1) In /index.jsp: a) What's the purpose of the empty <ul> under Quick Index? b) You could make the html more legible by putting the flash and dhtml <a>'s on separate lines in the source. 2) In quick-index.xslt (and elsewhere): should Laszlo Explorer be renamed OpenLaszlo Explorer? On 2006-09-26, at 02:19 EDT, Jim Grandy wrote: > Change change.v4F495TPG.txt by [EMAIL PROTECTED] /Volumes/ > data/Users/jgrandyw/dev/svn/openlaszlo/branches/legals/ on > 2006-09-25 23:08:57 PDT > > Summary: Partial cut at cleaning up OOBE and Explorer experience > for PR4 > > New Features:Update top-level index files and wrappers for small > applications. > > Technical Reviewer: ptw (pending) > QA Reviewer: ben (pending) > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details:Wrapper pages for Weather, Vacation Survey, Contact List, > and Image Loading all improved to use lzt=html app loading as well > as to have "Show in DHTML" / "Show in SWF" buttons visible > depending on which runtime is being used. > > Also, internal OpenLaszlo home page index.jsp, SDK homepage quick- > index.html, and docs/index.html updated to be XHTML compliant and > to use "OpenLaszlo" instead of "Laszlo Presentation Server" or "LPS" > > And, index.jsp greatly expanded to include direct DHTML and Flash > links for all demos, and examples, including the components > examples. The "Laszlo Explorer" links go to the full Laszlo > Explorer for SWF, and the cut down "Legals Explorer" for DHTML. > > Finally, added "ant quick-index-legals" task to build "quick-index- > legals.html" containing just the demos and examples that are > provided within laszlo-explorer/nav-legals.xml. > > Note that Laszlo Explorer is only partially updated. I'm intending > to modify the code so that the lzr= value is passed from the > wrapper into nav-explore.lzx and from there into the right-pane > content. There are also a number of other cosmetic and functional > changes that need to be made. And quick-index.html / quick-index- > legals.html still need quite a bit of work. > > > Tests: > > Files: > M docs/index.html > A lps/includes/utils.js > M build.xml > M laszlo-explorer/index.jsp > M laszlo-explorer/nav-legals.xml > M index.jsp > M demos/vacation-survey/vacation-survey.html > M demos/weather/weather.html > M quick-index.xslt > M examples/contactlist/contactlist.html > M examples/image-loading/image-loading.html > > <patch.jgrandyw.02Hk.tgz> _______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
