This looks good. The only thing I might ask is to merge the repeated code
in LzNode.prototype.setOption and LzNode.prototype.__LZsetOptions

A

On Sep 26, P T Withington wrote:

> Change change.zpAulUWBZ.txt by [EMAIL PROTECTED]
> /Users/ptw/pending-changes/ on 2006-09-18 13:07:00 EDT
> 
> Summary: Make node options type safe
> 
> Technical Reviewer: adam (pending)
> QA Reviewer: henry (pending)
> Doc Reviewer: (pending)
> 
> Details:
>    LzNode, LzUserClass: only merge Arrays and Objects in the
>    magic-attrs loop.
> 
>    LzNode: Add options as one of the special LzInhertedHash class
>    properties.  Add a setter for options that correctly accumulates
>    options.  Use a sentinel hash for options.  Replace the sentinel
>    in the setter.
> 
>    LzUserClass: add a _dbg_name.
> 
> Tests:
>    Test case from LPP-2751
> 
> Files:
> M      core/LzNode.lzs
> M      core/UserClass.lzs
> 

_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev

Reply via email to