Questions:

1) What is lzx-catalog?  Is this something for packaging/ 
distribution?  Could you check with Davis that it is really not needed?

2) Is there a missing modifier in this comment:

> Note that this change does attempt to fix problems with controlling

?

Otherwise, approved.

On 2006-10-07, at 00:38 EDT, Benjamin Shine wrote:

> Change change.Reltj8h6h.txt by [EMAIL PROTECTED] /Users/ben/src/svn/ 
> openlaszlo/branches/legals on 2006-10-06 21:20:39 PDT
>
> Summary: Clean up main build.xml without changing functionality
>
> New Features:
>
> Bugs Fixed:
>
> Technical Reviewer: ptw
> QA Reviewer: jgrandy
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> This is simply a "no broken windows" change, which should not change
> functional behavior, but only tidies up the main build.xml file.
>
> Several spurious, verbose "echo" statements were removed from the init
> target.
>
> The "doc" target was cleaned up a bit, but not functionally  
> changed. It
> still does not invoke the doc build; this is intentionally turned off
> in legals. This change replaces the <?ignore ?> preprocessor  
> instruction
> with a standard xml comment.
>
> Several old, used targets were hanging around in build.xml. This  
> change
> removes the following three targets, which seem to not have been used
> since the ant 1.6 upgrade:
>    lzx-catalog
>    commons-logging-to-tomcat
>    clean-commons-logging-from-tomcat
>
> Several condition elements were present in two places in the build  
> file;
> this was a copy-and-paste error. Duplicate defintions of the following
> condition elements have been removed:
>     tom.stop for windows and non-windows
>     tom.start for windows and non-windows
>
> Note that this change does attempt to fix problems with controlling
> tomcat on windows.
>
> Tests:
>
> Files:
> M      build.xml
>
> <patch.ben.JcF3.tgz>


_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev

Reply via email to