Comments:
1) Your editor apparently sticks lots of attributes into text files,
and your tar bundles them up as ._<filename>. Just an annoyance, I
guess, but it would be nice to teach your tar to not bother with
these attributes for the purposes of review. (What tar are you using?)
2) Rather than output discrete information about the build, etc. for
each log entry, why not just once per run output
canvas.versionInfoString()?
Otherwise, approved.
On 2006-11-06, at 18:49 EST, Benjamin Shine wrote:
Change 20061106-ben-p by [EMAIL PROTECTED] on 2006-11-06 15:33:58 PST
in /Users/ben/src/svn/openlaszlo/branches/legals/test
Summary: Extensions to performance logger to record more info about
the runtime
New Features:
Bugs Fixed:
Technical Reviewer: ptw (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Now we report tons of information to be logged by the reporter.jsp,
including
all the numbers about a particular meter (with number of runs, min,
max, and
uncertainty). We also record the User-Agent http header, the ip
address of the
client, and the runtime.
Log info now looks like this:
testname=newView suitename=viewperf duration=1.5699999999999998
count=10 min=0.95 max=2.6 uncertainty=0.5390732788777421
runtime=dhtml buildid=2405 debug=false
builddate=2006-11-06T13:49:41-0800 browserinfo=Mozilla%2F5.0+%
28Macintosh%3B+U%3B+Intel+Mac+OS+X%3B+en-US%3B+rv%3A1.8.1%29+Gecko%
2F20061010+Firefox%2F2.0 comment=127.0.0.1
Dialed down number of runs per test to make the tests complete faster.
Release Notes:
Details:
Tests:
http://localhost:8080/legals/test/lfc/perf/viewperf.lzx?lzr=dhtml
http://localhost:8080/legals/test/lfc/perf/viewperf.lzx?lzr=swf7
http://localhost:8080/legals/test/lfc/perf/viewperf.lzx?lzr=swf8
Examine the file in test/lfc/perf/results.txt
Files:
M lfc/perf/cssperf.lzx
M lfc/perf/typeof.lzx
M lfc/perf/viewperf.lzx
M lfc/perf/reporter.jsp
M lfc/perf/timing-classes.lzx
M lfc/perf/reporter.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061106-
ben-p.tar
Benjamin Shine
Software Engineer, Open Laszlo / Laszlo Systems
[EMAIL PROTECTED]
