Approved.
-Max
P T Withington wrote:
Change 20061106-ptw-5 by [EMAIL PROTECTED] on 2006-11-06 17:57:44
EST
in /Users/ptw/OpenLaszlo/trunk
Summary: Note instantiation progress for splash if ratio < 1
Bugs Fixed:
LPP-2942: Splash is still broken (with or without ratio)
Technical Reviewer: max (pending)
QA Reviewer: mamye (pending)
Doc Reviewer: jsundman (pending)
Documentation:
The world was under the illusion that if they set the
ratio for the <splash> tag to something less than one, the first
phase of the splash animation noted load progress, while the
second phase noted instantiation progress. This was apparently
never true, and when lzpreloader was fixed to actually obey its
ratio parameter, many were disappointed. Our illustrious Chief
Architect has deemed that I should "make it so". This has been
done. I have set some bleachers up in the sun...
The documentation should be updated to reflect the folk wisdom.
Details:
lzpreloader: Update/remove stale comments. Pass ratio and
totalframes to persisted views. If ratio is < 1, animate
remainder of presisted views against canvas.percentcreated.
amazon: Remove (now redundant) animation against
canvas.percentcreated.
Tests:
demos/amazon/amazon.lzx animates it's splash all the way across
Files:
M WEB-INF/lps/lfc/lzpreloader.as
M demos/amazon/amazon.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061106-ptw-5.tar
