I'll review it, since I was just in that code for CSS last week.
On Nov 7, 2006, at 2:14 PM, Max Carlson wrote:
Sorry, I need to have someone else review the bug before approving.
Henry, can you do a review? Thanks!
I've filed a bug here, to track it
http://jira.openlaszlo.org/jira/browse/LPP-3027
-Max
Naoki Kurosawa wrote:
Hi Max,
I made a patch to add new dependency checking option. New
'checkExceptLPSDir' option checks all user's source file except lps
directory and children.
I think this option is useful for unarchived deploy. (Web application
is directory, not archived WAR) If we use unarchived deploy, cache is
recycled. So we have to use 'check' option. But 'check' option is a
little slow.
Actually, we should use 'never' option with clearing cache per
deploy.
But average user don't care about it, and they fall a prey to pit.
In this context, this option may be a pit of the same kind, likes
"Why
isn't this updated?" So I don't think we should make this default.
Here is a result of performance test.
(Pentium M 2GHz, MEM:1GB,
Server and client are on same machine. Therefore, I'd like you to
understand this is a rough test.)
/my-apps/copy-of-hello.lzx?lzt=swf
request/sec
check: 13.7
checkExceptLPSDir: 182.6
never: 207.0
with If-Modified-Since header (network traffic is very low)
check: 23.3
checkExceptLPSDir: 341.8
never: 484.1
/demos/weather/weather.lzx?lzt=swf
request/sec
check: 8.6
checkExceptLPSDir: 107.8
never: 139.2
with If-Modified-Since header
check: 14.5
checkExceptLPSDir: 238.7
never: 478.3
/demos/dashboard/dashboard.lzx?lzt=swf
request/sec
check: 3.4
checkExceptLPSDir: 13.1
never: 57.3
with If-Modified-Since header
check: 5.6
checkExceptLPSDir: 25.1
never: 485.2
It is slow when files are many :)
Regards,
Naoki Kurosawa
[EMAIL PROTECTED]
<20061103-naoki-0.tar.gz>
Benjamin Shine
Software Engineer, Open Laszlo / Laszlo Systems
[EMAIL PROTECTED]
