Ok, I've added a second parameter to dhtmlEmbedLFC, documented as
follows:
* @param allowUnsupported:(true|false|undefined) if true, there
* will be no check for unsupported browsers -- the LFC and app
* will be loaded and executed. If false, unsupported browsers
* will not be permitted and a notice that the browser is not
* supported will be displayed. If undefined or omitted, the user
* will queried if they want to 'try anyway' if the browser is
* unsupported -- clicking `OK` (or `Cancel) will have the same
* effect as a `true` (or `false`) value for this parameter
The browser check is only on dhtmlEmbedLFC, which must be called
first. dhtmlEmbed, which embeds the app, will be a no-op if
dhtmlEmbedLFC has not been called or the browser is unsupported (and
allowUnsupported or the user query has not overridden the check).
On 2006-11-17, at 13:15 EST, Jim Grandy wrote:
This is what I originally proposed -- that there be a preflight API
call available in the embedding library to check compatibility, and
then a parameter to the embed function that disables the check. I
still think it would be the right thing to do.
On Nov 17, 2006, at 9:29 AM, Neil Mix wrote:
Might I suggest that the browser check and confirmation dialog be
factored out separately so that a developer can provide custom
behavior to deal with incompatible browsers? (With support for
asynch confirmation?) Gosh but gosh do I hate modal alert dialogs...
On Nov 17, 2006, at 10:41 AM, Jim Grandy wrote:
Yes, please.
http://www.openlaszlo.org/jira/browse/LPP-3118
jim
On Nov 16, 2006, at 6:26 PM, Max Carlson wrote:
We could add a checkbox that sez you understand and sets a
cookie to 'remember' - easily done with a little javascript.
Once Tucker's change is in, I can add this if you like...
-Max
Jim Grandy wrote:
I still think there should be an override, and not just for the
developer -- what if you are the poor user of a "B List"
browser where we mostly work -- like Opera -- and you have to
continually click through this annoying dialog?
On Nov 16, 2006, at 2:12 PM, Max Carlson wrote:
Approved, provided you change 'anyways' to 'anyway' :P
-Max
P T Withington wrote:
Change 20061116-ptw-P by [EMAIL PROTECTED] on
2006-11-16 16:01:43 EST
in /Users/ptw/OpenLaszlo/legals-2/lps/includes
Summary: Browser detect in embed-dhtml.js
New Features: If you use embed-dhtml to embed your dhtml OL
app, it
will automatically check for supported browsers. For
browsers that
are not 'A List' browsers, there will be an alert:
"The OpenLaszlo DHTML runtime is not fully supported on this
browser.
Click OK to try it anyways."
If you click 'OK', the LFC and app will attempt to load and
run. If you
click 'Cancel', the app will be replaced with a note:
"The OpenLaszlo DHTML runtime is not fully supported on this
browser.
More information is available <a href="http://
www.openlaszlo.org/"
target="_top">here</a>"
Bugs Fixed:
LPP-2774: 'Add browser detect to basic wrappers'
Technical Reviewer: max (pending)
QA Reviewer: mamye (pending)
Doc Reviewer: (pending)
Details:
Copied browser-detect logic from LZPIX to embed-dhtml.
Added
queyr if browser is not supported. For unsupported
browsers, LFC
is not imported and app is replaced with pretty note.
Tests:
As a test, set the browser-detect logic to return
unsupported for
all browsers. Loaded
demos/vacation-survey/vacation-survey.lzx?lzr=dhtml and
?lzr=dhtml&lzt=html in Win IE, FF, and Mac Safari, FF.
Got alert
and pretty note. Set logic back, repeated test, got no
alert.
Tried in Mac Opera, got alert.
Files:
M embed-dhtml.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/
20061116-ptw-P.tar
