Great!
Thank you,
- David
On Nov 22, 2006, at 1:23 PM, Sarah Allen wrote:
This looks like a better approach, thanks! change accepted and
checked in. I improved your comment on teh stop method to provide
a little more detail on the difference between pause and stop and
also updated the change notes to detail the additional attributes
and methods that support these fixes (below)...
Summary: various bug fixes and "mode" now reflects broadcasting,
playing and recording
New Features:
* broadcasting, playing and recording convenience attributes, where
broadcasting reflects that we are actually broadcasting when
recording or broadcasting
* paused attribute, and pause method (mimics animator semantics)
* Added muteaudio and mutevideo attributes to check/set muting.
Bugs Fixed:
LPP-3092 In mediastream, _setCam and _setMic need to send the oncam
and onmic events.
LPP-3091 no way to tell if a mediastream is broadcasting
LPP-3090 No way to mute the video on a particular stream
LPP-3089 No way to mute the audio on a particular stream
Technical Reviewer: sallen
QA Reviewer: tbd
Doc Reviewer: sallen
Documentation:
inline comments will show up in reference
New test file:
test/video/test-muting-and-playing.lzx
On Wed, Nov 22, 2006 at 1:04 PM, [EMAIL PROTECTED] wrote:
Oops! Sorry, here it the latest and greatest. (I must have not
subversioned properly.)
- David
------------------------------
On Nov 22, 2006, at 12:53 PM, Sarah Allen wrote:
odd.. this seems like exactly the same change... maybe the svn
change package thing got confused....
On Tue, Nov 21, 2006 at 11:12 PM, [EMAIL PROTECTED]:
Change 20061121-ungar-E by [EMAIL PROTECTED] 2006-11-21 14:07:09
PST
in /Users/ungar/src/svn/openlaszlo/trunk
Summary:
New Features:
Bugs Fixed:
LPP-3092 In mediastream, _setCam and _setMic need to send the oncam
and onmic events.
LPP-3091 no way to tell if a mediastream is broadcasting
LPP-3090 No way to mute the video on a particular stream
LPP-3089 No way to mute the audio on a particular stream
Technical Reviewer: sallen (pending)
QA Reviewer: tbd (pending)
Doc Reviewer: sallen (pending)
Documentation:
Added broadcasting attribute to see if stream is broadcasting.
(Implementation of same could be better by expanding possible
values of "mode".)
Added muteaudio and mutevideo attributes to check/set muting.
Added line of code to falsify "playing" attribute when stream stops
playing.
Added oncam and onmic event sending to setters.
Release Notes:
Details:
Tests:
test/video/test-muting-and-playing.lzx
Note: the following tests do not work for me with either the
baseline mediastream or with mine:
test-video-rtmp.lzx < http://localhost:8080/trunk/test/video/test-
video-rtmp.lzx?debug=true> <http://localhost:8080/trunk/test/video/
test-video-rtmp.lzx?debug=true>
test-stream-video.lzx < http://localhost:8080/trunk/test/video/test-
stream-video.lzx?debug=true> <http://localhost:8080/trunk/test/
video/test-stream-video.lzx?debug=true>
test-stream-video-sep.lzx < http://localhost:8080/trunk/test/video/
test-stream-video-sep.lzx?debug=true> <http://localhost:8080/trunk/
test/video/test-stream-video-sep.lzx?debug=true>
test-stream-video-rtmp.lzx < http://localhost:8080/trunk/test/video/
test-stream-video-rtmp.lzx?debug=true> <http://localhost:8080/trunk/
test/video/test-stream-video-rtmp.lzx?debug=true>
test-stream-video-rtmp-sep.lzx < http://localhost:8080/trunk/test/
video/test-stream-video-rtmp-sep.lzx?debug=true> <http://localhost:
8080/trunk/test/video/test-stream-video-rtmp-sep.lzx?debug=true>
test-recording.lzx < http://localhost:8080/trunk/test/video/test-
recording.lzx?debug=true> <http://localhost:8080/trunk/test/video/
test-recording.lzx?debug=true>
test-microphone-recording.lzx < http://localhost:8080/trunk/test/
video/test-microphone-recording.lzx> <http://localhost:8080/trunk/
test/video/test-microphone-recording.lzx>
<http://localhost:8080/trunk/test/video/test-microphone-recording.lzx>
<http://localhost:8080/trunk/test/video/test-microphone-recording.lzx>
Files: <http://localhost:8080/trunk/test/video/test-microphone-
recording.lzx>
A test/video/test-muting-and-playing.lzx <http://localhost:
8080/trunk/test/video/test-microphone-recording.lzx>
M lps/components/extensions/av/mediastream.lzx <http://
localhost:8080/trunk/test/video/test-microphone-recording.lzx>
<http://localhost:8080/trunk/test/video/test-microphone-recording.lzx>
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061121-
ungar-E.tar<http://svn.openlaszlo.org/openlaszlo/patches/20061121-
ungar-E.tar>
