Hi Max,

I found 2 problems with the dhtml version of getDepthList().

1. If there are no subviews; this.__children is null and an error is generated.
2. If there is a single subview, the function returns an empty array.


LzSprite.prototype.getDepthList = function(){
    var c = this.__children;
    var o = [];
    if (c.length < 2) return o;
    c.sort(LzSprite.prototype.__zCompare);
    for (var i = 0; i < c.length; i++) {
        o[i] = c[i].owner;
    }
    return o;
}


Change 20070104-maxcarlson-h by [EMAIL PROTECTED]
computer.local on 2007-01-04 16:46:31 PST
     in /Users/maxcarlson/openlaszlo/legals

Summary: Get lztest-view.lzx closer to running in 4.0

New Features: Added getDepthList() method back to view, swf view size
measurement now accurate for views without resources.

Bugs Fixed:

Technical Reviewer: promanik
QA Reviewer: hminsky
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: lztest-view.lzx now gets a lot closer to passing, failing in
similar ways in both swf and dhtml.  LzSprite.as - update view
resourcewidth/height for sprites without resources and add public
getDepthList() method.  LzSprite.js - added public getDepthList()
method.  LaszloView.lzs - getDepthList() calls sprite
implementation.  Add missing spacer.gif to lztest.  lztest-view.lzx
updated to use local spacer.gif and to show view x values settling
down after the test fails.


Tests: test/lztest/lztest-view.lzx in SWF and DHTML

Files:
M      test/lztest/lztest-view.lzx
A      test/lztest/spacer.gif
M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/views/LaszloView.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070104-
maxcarlson-h.tar

Reply via email to