Re: [Laszlo-dev] For Review: Change 20070104-ptw-n Summary: Make style constraints play nice

[Benjamin Shine]

Approved.

On Jan 4, 2007, at 7:03 PM, P T Withington wrote:

Change 20070104-ptw-n by [EMAIL PROTECTED] on 2007-01-04 15:50:27 EST

    in /Users/ptw/OpenLaszlo/trunk

Summary: Make style constraints play nice

Bugs Fixed:

LPP-2894: 'CSS: subclasses and instances can't override style constraints set on superclass*'

Technical Reviewer: ben (pending)
QA Reviewer: adam (pending)
Doc Reviewer: (pending)

Details:
    subclassing.lzx: Added styleinnercolor, just so I can understand
    what the test was trying to do.  Added a more complex dependency,
    using an `attr()` style to 'stress-test' style constraints

    LzNode.as: __LZapplyStyle map now checks to make sure to _not_
    constrain an attribute that has an explicit value.  It splits
    style constraints into constant and computed constraints, the
    computed constraints are applied after the node is init-ed, since
    those constraints may depend on other node attributes.

CSSHandler.java: SAC_ATTR and SAC_IDENT values should be computed values.

Tests:
    test/style/constraints/subclassing.lzx

Files:
M      test/style/constraints/subclassing.lzx
M      WEB-INF/lps/lfc/core/LzNode.as
M      WEB-INF/lps/server/src/org/openlaszlo/css/CSSHandler.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070104- ptw-n.tar