Approved! Thanks, Max.
On Feb 22, 2007, at 8:58 PM, Max Carlson wrote:
Change 20070222-maxcarlson-4 by [EMAIL PROTECTED]
computer.local on 2007-02-22 16:38:54 PST
in /Users/maxcarlson/openlaszlo/legals
Summary: UPDATED - Fix setText(0) and text height measurement for
empty textfields in DHTML
New Features: setText() always coerces to a string
Bugs Fixed: LPP-3007 - DHTML:Missing minimum value on the slider,
LPP-3585 - Empty text object in DHTML has height of 0
Technical Reviewer: jcrowley
QA Reviewer: promanik
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: Since 0 == '' is true in browser javascript, calling
setText(0) failed since setText returns immediately if you're
setting it to the same value.
LzTextSprite.js - remove string coercion in setText(). Measure
'Yq_gy' for empty text fields to get height of text field as if it
had a single line. getTextSize() checks argument instead of
this.text.
LzInputText.lzs - coerce setText() argument to a string
LzText.lzs - coerce setText() argument to a string
Tests: http://localhost:8080/legals/examples/components/
slider_example.lzx?lzr=dhtml&debug=true now shows the minimum value
(0)
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M WEB-INF/lps/lfc/views/LzInputText.lzs
M WEB-INF/lps/lfc/views/LzText.lzs
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070222-
maxcarlson-4.tar
