Re: [Laszlo-dev] For Review: Change 20070306-maxcarlson-2 Summary: Source editor now uses default lzr, allows specification of runtime and title

[Philip Romanik]

Approved if you make one small change. In source.jsp, the query parameters 
are separated by an escaped '&' (ie. &).  However, the new 'lzr' 
parameter is using a '&'.  I don't remember the issue regarding this but 
the escaping is important.

String lzr = request.getParameter("lzr");
if (lzr != null) {
  lzr = "&lzr=" + lzr;   <--- Should be lzr = "&amp;lzr=" + lzr;
} else {
  lzr = "";
}

Change 20070306-maxcarlson-2 by [EMAIL PROTECTED]
computer.local on 2007-03-06 13:30:16 PST
     in /Users/maxcarlson/openlaszlo/legals-clean

Summary: Source editor now uses default lzr, allows specification of
runtime and title

New Features: editor.jsp now allows specification of lzr and title,
e.g http://localhost:8080/legals-clean/laszlo-explorer/editor.jsp?
src=docs/reference/programs/LFC-$8.lzx&title=Example+8&lzr=dhtml

Bugs Fixed: LPP-3645 - Online code browser is demanding a runtime value

Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:  editor.jsp - Pass through lzr parameter.  Test for null
value of apptitle.

source.jsp - Check for null title.  Test for null lzr parameter and
pass "", otherwise pass parameter through.


Tests: Build docs (ant doc) then run http://localhost:8080/legals-
clean/laszlo-explorer/editor.jsp?src=docs/reference/programs/LFC-
$8.lzx.  You can also run http://localhost:8080/legals-clean/laszlo-
explorer/editor.jsp?src=docs/reference/programs/LFC-
$8.lzx&title=Example+8&lzr=dhtml to test the runtime is dhtml and the
title is set.

Files:
M      laszlo-explorer/editor.jsp
M      laszlo-explorer/source.jsp

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070306-
maxcarlson-2.tar