approved

On 5/2/07, P T Withington <[EMAIL PROTECTED]> wrote:
Change 20070502-ptw-8 by [EMAIL PROTECTED] on 2007-05-02 15:24:43 USEST
     in /home/ptw/OpenLaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Correctly enumerate includes of binary libraries

Bugs Fixed:
LPP-3937 'lzmail vs. binary libraries'

Technical Reviewer: hminsky (pending)
QA Reviewer: sallen (pending)
Doc Reviewer: n/a

Details:
     LibraryCompiler: Add some logging to monitor include processing

     ToplevelCompiler: Enhance collectReferences to record the includes
     included by each include.

     LibraryWriter: Use that information to not reference included that
     are included by includes you are already including.

     FileResolver: Clean up canonicalization of files when resolving.

Tests:
     lzc future/lzmail/main.lzx gets further now.  Now it stops because
     it can't find an include that _is_ explicitly included, but is not
     built by the `ant build-libraries` task.

     Also, inspected the resulting binary libraries manually and
     verified that they were as should be expected.

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/
LibraryCompiler.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/
ToplevelCompiler.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/LibraryWriter.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/FileResolver.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070502-
ptw-8.tar




--
Henry Minsky
Software Architect
[EMAIL PROTECTED]

Reply via email to