Approved.

Maybe you should take the task of enhancing the compile-time conditional processor to evaluate arbitrary expressions? :P

On 2007-05-02, at 17:09 EDT, Jim Grandy wrote:

Change 20070502-jgrandyw-C by [EMAIL PROTECTED] on 2007-05-02 14:01:15 PDT
    in /Users/jgrandyw/dev/svn/openlaszlo/branches/legals2
    for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: js2doc: Introduce idea of "runtime aliases" to handle composite runtimes

New Features:

Bugs Fixed: LPP-3939

Technical Reviewer: ptw
QA Reviewer:
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

In the version of the refguide that shipped in 4.0.0, I only recognized a simple set of runtime tags: basically as2, dhtml. But in looking into
a bug related to documentation of LzTrack, I realized that my model of
things was too simplistic. LzTrack has a version for $as2, but also a
version for $js2, which js2doc totally ignores at the moment.

After some investigation, I saw the problem. It appears as though there
is a set of explicit runtimes, and then a set of composite runtimes:

simple: swf7, swf8, swf9, dhtml, svg, j2me compound: as2, as3, js2

as2 === (swf7 || swf8 || swf9) as3 === (swf9) js2 === (dhtml || svg ||
j2me)

So I implemented a "runtime alias" feature is js2doc that basically
encodes these equalities. Whenever I see "as2", I act as though I had
seen "swf7 || swf8 || swf9".

Since svg and j2me are not supported runtimes, I've left them out of the
js2doc-specific definition of 'dhtml'.



Tests:

Files:
M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ test_include.xml M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ unitcomment.xml M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ unitcomment2.xml M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ LaszloEvents.xml
M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/shortest.xml
M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ simplecomment.xml
M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/JS2Doc_Test.java
M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/JS2Doc.java
M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/Main.java
M WEB-INF/lps/server/src/org/openlaszlo/js2doc/ WholeFile_Test.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070502- jgrandyw-C.tar

Reply via email to