Better now. Approved.
On Jun 25, 2007, at 1:59 PM, P T Withington wrote:
Can you try again? I updated the tar file. When I run I see the
following output:
DEBUG: Source warnings enabledWARNING: testing:0: Test source warning
ERROR: couldn't find dataset for 'http:/root'
ERROR: couldn't find dataset for 'http2:/root/child'
ActionScriptSemantics: 11 tests skipped for runtime dhtml
ERROR: Expected: expected false got true
ERROR: Expected: expected false got 1
ERROR: Expected: expected false got '1'
ERROR: Expected: expected false got '1492'
ERROR: Expected: expected false got «Array(0)#9| []»
ERROR: Expected: expected false got «Object#11| {}»
ERROR: Expected: expected true got false
ERROR: Expected: expected true got null
ERROR: Expected: expected true got 0
ERROR: Expected: expected true got ''
ERROR: Expected: expected true got «undefined»
ERROR: Expected: expected true got NaN
ERROR: Expected: expected null got 'null'
ERROR: Expected: expected 'undefined' got «undefined»
ERROR: Expected: expected NaN got 0
ERROR: Expected: expected 1 got 'one'
ERROR: Expected: expected 1 got 'true'
ERROR: Expected: expected 'true' got '1'
ERROR: Expected: expected '0±0.01' got 0.1
ERROR: Expected: expected '0±1.7976931348623157e+308' got Infinity
ERROR: Expected: expected '0±0' got 1e-307
ERROR: Expected: expected anything but «undefined» got «undefined»
ERROR: Expected: expected anything but null got null
ERROR: Expected: expected anything but 1 got 1
ERROR: Expected: expected anything but Infinity got Infinity
ERROR: Expected: expected anything but 0 got 0
ERROR: Expected: expected anything but true got true
ERROR: Expected: expected NaN got Infinity
ERROR: Expected: expected Infinity got NaN
ERROR: Expected: expected '' got ' '
ERROR: Expected: expected true got false
ERROR: Expected: expected «Object#38| {zot: qux}» got «Object#39|
{zot: qux}»
ERROR: Expected: expected 'non-null value' got null
ERROR: Expected: expected null got ''
ERROR: Expected: expected null got «Array(0)#43| []»
ERROR: Expected: expected null got «Object#45| {}»
ERROR: Expected: expected 'defined value' got «undefined»
ERROR: Expected: expected 'undefined value' got ''
ERROR: Expected: expected 'undefined value' got «Array(0)#49| []»
ERROR: Expected: expected 'undefined value' got «Object#51| {}»
Expected error: This is an intentional error
Expected error: testing: 1, 2, 3
WARNING: This is a test
Expected error: This is a test
INFO: Expect an excess arguments warning
WARNING: '%': excess arguments
INFO: Expect an excess arguments warning
WARNING: '%1': excess arguments
INFO: Expect an excess arguments warning
WARNING: '1%': excess arguments
expect: couldn't find dataset for http:/root
expect: couldn't find dataset for http2:/root/child
WARNING: setVisible(null) is deprecated, use setVisibility
('collapse') instead
WARNING: setVisible(null) is deprecated, use setVisibility
('collapse') instead
WARNING: setVisible(null) is deprecated, use setVisibility
('collapse') instead
WARNING: setVisible(null) is deprecated, use setVisibility
('collapse') instead
WARNING: setVisible(null) is deprecated, use setVisibility
('collapse') instead
On 2007-06-25, at 16:37 EDT, Benjamin Shine wrote:
Not approved -- this doesn't seem to fix the bug.
I applied your changes, rebuilt, and ran the smokecheck at
http://localhost:8080/legals/test/smoke/smokecheck.lzx?lzr=dhtml
at the end I see...
ERROR: http://localhost:8080/legals/lps/includes/lfc/LFCdhtml-
debug.js:675: this.warn is not a function
which comes out to be right in the middle of LzFormat.lzs
Debug.formatToString.
On Jun 25, 2007, at 12:51 PM, P T Withington wrote:
[RESENT: Ben, would you be able to look at this soon, or should
I nominate another reviewer? I know you are probably knee-deep
in merges, maybe you want a distraction, maybe not. I'd like to
check it in so Frisco can QA -- community bug.]
Change 20070622-ptw-C by [EMAIL PROTECTED] on 2007-06-22
08:36:04 EDT
in /Users/ptw/OpenLaszlo/legals-1
for http://svn.openlaszlo.org/openlaszlo/branches/legals
Summary: Robustify Debug.format's 'write compatibility' mode
Bugs Fixed:
LPP-4141 'Debugger enabled when JavaRpc returns a String
containing '%' causes an error'
Technical Reviewer: ben (pending)
QA Reviewer: frisco (pending)
Doc Reviewer: (pending)
Details:
LzFormat: Fix type-oh that caused warning to fail (as
reported in
bug). Make 'write compatibility' detector smarter. Make
dealing
with unknown or incomplete control strings smarter (just echo
the
unknown control). Print excess args in compatibility mode.
debugger: Added some test cases to verify that compatibility
mode
works with random '%' characters.
Tests:
Test case from bug added to debugger smoke check
Files:
M test/smoke/debugger.lzl
M WEB-INF/lps/lfc/debugger/LzFormat.lzs
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070622-
ptw-C.tar
