technical review: Approved.
QA: Not approved.
1. http://localhost:8080/legals/lps/components/extensions/test/html.lzx
Loading openlaszlo.org generates an error in swf and dhtml:
uncaught exception: Permission denied to set property Window.Query
I know this is an issue with the openlaszlo.org website so the test files
should load a safer page instead.
2. Running the LPP-4197 sample app produces different results depending on
browser. Here's is the app I used (I modified the url and looking for onready):
<canvas debug="true">
<include href="extensions/html.lzx"/>
<class name="browser" extends="window" resizable="true" bgcolor="silver">
<html name="htmlview" width="${parent.width - 19}"
height="${parent.height - 74}" x="${parent.x + 7}" y="${parent.y + 53}"
visible="true">
<method event="onready">
this.setSrc('http://w3.org');
</method>
</html>
</class>
<browser width="500" height="500" x="10" y="10"/>
</canvas>
IE6/swf7. I had to click the view in order for the web page to be displayed
IE6/dhtml. ok
FF1.5/2.0 swf7. No display except when the browser window is resized or
scrolled
FF1.5/2.0 dhtml. blank window
Change 20070626-maxcarlson-X by [EMAIL PROTECTED] on 2007-06-26
17:50:23 PDT
in /Users/maxcarlson/openlaszlo/legals-clean
for http://svn.openlaszlo.org/openlaszlo/branches/legals
Summary: Add onready event handler to html tag
New Features:
Bugs Fixed: LPP-4197 - html component doesn't work correctly in swf
runtime
Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: test/html.lzx - '<method event=' changed to '<handler
name='. Added test for onready event that loads the site immediately.
html.lzx - Remove unused frame attribute. Add 'ready' attribute
which is set to true once the iframe is ready to use. Event is sent
when the iframe is ready and the component is initted, whichever
comes first. Warn if setSrc() is called before the iframe is ready.
iframemanager.js - Set skiponload to false for early calls to setSrc
(). Enhance debugging calls.
Tests: http://localhost:8080/legals-clean/lps/components/extensions/
test/html-swf.jsp and http://localhost:8080/legals-clean/lps/
components/extensions/test/html.lzx?lzr=dhtml&lzt=html both load the
page immediately. The testcase under LPP-4197 loads when 'oninit' is
changed to use the 'onready' event.
Files:
M lps/components/extensions/test/html.lzx
M lps/components/extensions/html.lzx
M lps/includes/source/iframemanager.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070626-
maxcarlson-X.tar
