Approved.
Change 20071026-ptw-V by
<mailto:[EMAIL PROTECTED]>[EMAIL PROTECTED] on 2007-10-26
15:54:26 EDT
in /Users/ptw/OpenLaszlo/ringding-2
for
<http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Defuine Undefined instance variable in LzCommand
Bugs Fixed:
LPP-4590 'DHTML: Javascript error if menu Command missing "key"
attribute'
Technical Reviewer: promanik (pending)
QA Reviewer: sosullivan (pending)
Doc Reviewer: ben (pending)
Details:
Test for LzCommand#keys being null before using it. Also finished
implementation of DisplayKeys. Documented that LZCommand#keys can
be null.
Question for the doc reviewer: In the command open tag, you
specify the shortcut key combination with the attribute `key`, but
this is stored as the attribute `keys`. What is the proper way to
document this? I believe the `keys` attribute should be private
and I should be documenting the "virtual" attribute `key`
instead. Or should I be filing an API change request to rename
the `keys` attribute to `key`?
Tests:
Test case from bug no longer gets reported error.
Files:
M WEB-INF/lps/lfc/helpers/LzCommand.lzs
Changeset:
<http://svn.openlaszlo.org/openlaszlo/patches/20071026-ptw->http://svn.openlaszlo.org/openlaszlo/patches/20071026-ptw-
V.tar
