Henry, I'm still waiting for your review of this changeset. Any news for me?

- André

-------- Original-Message --------
Subject: For Review: Change 20071020-bargull-2 Summary: Two improvements for LzHTTPLoader.js
Date:   Sat, 20 Oct 2007 17:35:58 +0200
From:   André Bargull <[EMAIL PROTECTED]>
To:     Henry Minsky <[EMAIL PROTECTED]>
CC:     [email protected]



Change 20071020-bargull-2 by [EMAIL PROTECTED] on 2007-10-20 17:11:11
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Two improvements for LzHTTPLoader

New Features:

Bugs Fixed:
LPP-4945 - Improvements for "LzHTTPLoader.prototype.loadXMLDoc"

Technical Reviewer: hminsky
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
Timeout checking was not removed for erroneous requests in non-proxied DHTML applications, this is now fixed. To test this, you need to uncomment the Debug.write statements in LzHTTPLoader.prototype.removeTimeout and LzHTTPLoader.__LZcheckXMLHTTPTimeouts. You can see, that erroneous requests were still checked against timeouts. Additionally, the try..catch block in "LzHTTPLoader.prototype.loadXMLDoc" has been shortened, because it was catching just too much errors. Sounds strange, but the block was solely added to catch possible errors in Firefox when you read out XMLHttpRequest.status on a aborted request and just for this error!


Tests:

Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzHTTPLoader.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071020-bargull-2.tar


Reply via email to