Re: [Laszlo-dev] For Review: Change 20071220-ptw-4 Summary: Use modern class constructor syntax

Thu, 20 Dec 2007 22:55:21 -0800

Not approved - when I build this on a clean copy of trunk TOT (r7651) I can't get the servlet to start up at all. I suspect this is due to changes in web.xml... 

Here's the stacktrace from tomcat:
2007-12-20 22:42:09 StandardContext[/trunk-clean]Error configuring application listener of class org.openlaszlo.server.ApplicationWatch 
java.lang.ClassNotFoundException: org.openlaszlo.server.ApplicationWatch
at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1340) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1189) at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:3779) at org.apache.catalina.core.StandardContext.start(StandardContext.java:4323) at org.apache.catalina.core.StandardHostDeployer.start(StandardHostDeployer.java:830) 
        at org.apache.catalina.core.StandardHost.start(StandardHost.java:991)
at org.apache.catalina.manager.ManagerServlet.start(ManagerServlet.java:1326) at org.apache.catalina.manager.HTMLManagerServlet.start(HTMLManagerServlet.java:530) at org.apache.catalina.manager.HTMLManagerServlet.doGet(HTMLManagerServlet.java:104) 
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520) at org.apache.catalina.core.StandardContextValve.invokeInternal(StandardContextValve.java:198) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:152) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:137) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:118) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520) 
        at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:929)
        at 
org.apache.coyote.tomcat5.CoyoteAdapter.service(CoyoteAdapter.java:160)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:799) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:705) at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:577) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) 
        at java.lang.Thread.run(Thread.java:613)

P T Withington wrote:
Change 20071220-ptw-4 by [EMAIL PROTECTED] on 2007-12-20 16:36:26 EST 
    in /Users/ptw/OpenLaszlo/ringding-2
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Use modern class constructor syntax

Bugs Fixed:
LPP-5307 'Our class constructor/initializer don't match JS2'

Technical Reviewer: [EMAIL PROTECTED] (pending)
QA Reviewer: [EMAIL PROTECTED] (pending)

Details:
    CommonGenerator:  Output the initializer as a compiler function
    $lzsc$initizlize.  Translate super() calls to calls to
    super.$lzsc$initialize.

    Parser:  accept super() calls

    *: Rename initialize methods to the class name, use super() calls
     to invoke the superclass initializer.

Tests:
    smokecheck, sample apps

Files:
M      WEB-INF/web.xml
M      WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs
M      WEB-INF/lps/lfc/kernel/swf/LzMediaLoader.lzs
M      WEB-INF/lps/lfc/kernel/swf/LzContextMenu.lzs
M      WEB-INF/lps/lfc/kernel/swf/dojo/flash6/DojoExternalInterface.as
M      WEB-INF/lps/lfc/kernel/swf/dojo/flash8/DojoExternalInterface.as
M      WEB-INF/lps/lfc/kernel/swf/dojo/flash8/ExpressInstall.as
M      WEB-INF/lps/lfc/kernel/swf/LzLibraryLoader.lzs
M      WEB-INF/lps/lfc/kernel/dhtml/LzContextMenu.js
M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.lzs
M      WEB-INF/lps/lfc/kernel/swf9/LzHTTPLoader.lzs
M      WEB-INF/lps/lfc/kernel/swf9/LzLoader.lzs
M      WEB-INF/lps/lfc/kernel/swf9/LzMediaLoader.lzs
M      WEB-INF/lps/lfc/kernel/swf9/LzSoundMC.lzs
M      WEB-INF/lps/lfc/kernel/swf9/LzContextMenu.lzs
M      WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.lzs
M      WEB-INF/lps/lfc/kernel/swf9/LzLoadQueue.lzs
M      WEB-INF/lps/lfc/kernel/swf9/LzLibraryLoader.lzs
M      WEB-INF/lps/lfc/kernel/swf9/LzInputTextSprite.lzs
M      WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs
M      WEB-INF/lps/lfc/services/LzTrack.lzs
M      WEB-INF/lps/lfc/services/LzIdle.lzs
M      WEB-INF/lps/lfc/services/LzInstantiator.lzs
M      WEB-INF/lps/lfc/debugger/LzMemory.lzs
M      WEB-INF/lps/lfc/core/LzDictionary.lzs
M      WEB-INF/lps/lfc/core/LzNode.lzs
M      WEB-INF/lps/lfc/core/UserClass.lzs
M      WEB-INF/lps/lfc/views/LzScript.lzs
M      WEB-INF/lps/lfc/views/LzViewLinkage.lzs
M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M      WEB-INF/lps/lfc/build.xml
M      WEB-INF/lps/lfc/helpers/LzFont.lzs
M      WEB-INF/lps/lfc/events/LaszloEvents.lzs
M      WEB-INF/lps/lfc/data/LzDataText.lzs
M      WEB-INF/lps/lfc/data/LzDataRequest.lzs
M      WEB-INF/lps/lfc/data/LzDataElement.lzs
M      WEB-INF/lps/lfc/data/LzParsedPath.lzs
M      WEB-INF/lps/lfc/data/LzDataAttrBind.lzs
M      WEB-INF/lps/lfc/compiler/LzFormatter.lzs
M      WEB-INF/lps/lfc/compiler/Class.lzs
M      WEB-INF/lps/config/lps.xml
M      WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java
M      WEB-INF/lps/server/sc/src/org/openlaszlo/sc/Parser.jjt

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071220-ptw-4.tar


--
Regards,
Max Carlson
OpenLaszlo.org

Reply via email to