This statement just don't look right:

var $9=("$refs"in$8)&&$8.$refs;

You need at least one space after the in-operator:
("$refs"in $8)



Probably due to a similar cause. Don, you probably want to look in the unparser for other charAt, or startsWith or endsWith calls on the partially unparsed string which could be interfered with by the annotation.

On 2008-01-25, at 17:00 EST, Philip Romanik wrote:

This fixed weather, but demos like lzpix are still broken. If I run lzpix in dhtml/debug it runs, although you'll see errors if you start clicking on images. In non-debug mode you get an LzCanvas not defined, and a new error (shown twice):
 missing ) in parenthetical
 []
var $8=this.defaultattrs;var $9=("$refs"in$8)&&$8.$refs;var $10=null;for(var $11...
 LFCdhtml.js (line 349)


Change 20080125-dda-o by <mailto:[EMAIL PROTECTED]>[EMAIL PROTECTED] on 2008-01-25 14:06:29 EST
     in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildog
     for 
<http://svn.openlaszlo.org/openlaszlo/branches/devildog>http://svn.openlaszlo.org/openlaszlo/branches/devildog

 Summary: SWF9: fix unparser problem in inserting spaces

 New Features:

 Bugs Fixed: LPP-5234

 Technical Reviewer: ptw (pending)
 QA Reviewer: promanik (pending)
 Doc Reviewer: (pending)

 Documentation:

 Release Notes:

 Details:

 Errors reported by Phil with LzCanvas not defined.
We believe this is an unparsing bug. The new unparser adds annotations to the text (with line number, class info) that is eventually removed. So any code that examines unparsed strings must 'unannotate' to see the clear text string.

The weather demo that Phil noticed this error in for DHTML works fine for me (in DHTML and SWF8) before and after the fix, so I'm not 100% this will completely fix the error he is seeing, but it seems likely given the description.

 Tests:
   demo/weather
      SWF8+DHTML
   smokecheck
      SWF8+DHTML   (1 failure for SWF8, which was there previously)
   swf9/hello

 Files:
 M      WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java

Changeset: <http://svn.openlaszlo.org/openlaszlo/patches/20080125-dda-o.tar


 --

 Don Anderson
 Java/C/C++, Berkeley DB, systems consultant

 voice: 617-547-7881
 email: <mailto:[EMAIL PROTECTED]>[EMAIL PROTECTED]
 www: <http://www.ddanderson.com>http://www.ddanderson.com






Reply via email to