Change 20080211-dda-w by [EMAIL PROTECTED] on 2008-02-11 16:50:59 EST
in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildog
for http://svn.openlaszlo.org/openlaszlo/branches/devildog
Summary: SWF9: class name and file name conflict checks
New Features:
Bugs Fixed: LPP-5266
Technical Reviewer: ptw (pending)
QA Reviewer: hminsky (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
As agreed in review, compiler generated names should begin with
$lzsc$
(so interstitials are now named $lzsc$Name1$Name2...), and we can
be
more leniant on user's class names. This change disallows any
class
name beginning with '$'.
A related change is to protect against file names conflicting.
A previous test case had names like "foo" and "Foo" getting a file
overwritten on windows (file system maps "foo.as" and "Foo.as"
to the same file). This change prevents users from defining
two or more classes whose names that differ only by case (or that
are
the same). This is perhaps too conservative for Unix systems,
but may prevent cross-platform porting errors and seems to be
a reasonable limitation.
Tests:
did usual regression tests for swf8/dhtml:
smokecheck
lzpix
weather
did henry's hello for swf9.
made some local changes to LzNode to verify that class conflicts
and illegal names are detected.
Files:
M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080211-dda-w.tar
--
Don Anderson
Java/C/C++, Berkeley DB, systems consultant
voice: 617-547-7881
email: [EMAIL PROTECTED]
www: http://www.ddanderson.com
