99% of the component changes are dragging them into the modern era.
With 'real' classes, I want o get rid of defining the class globally
as the tag name (because, e.g., window, menu, etc. would get
clobbered). In the old code, if there was not a conflict, we defined
the global alias; but we have been telling people for some time now
that they need to say `lz.<tagname>` to get the class for a tag (for
`new` or `instanceof`). The components (and our demos) have never
been updated to obey this.
I'll have a look at the lzpixmobile.
On 2008-03-13, at 14:27 EDT, Max Carlson wrote:
Wow - that's a big change! It's a little alarming how many source-
level changes are required for components, etc. I tried running
trunk-clean/demos/lzpixmobile/main.lzx and got an error:
classes/mobilescroller.lzx:14:5: Syntax error: the token "with" was
not expected at this position.
<class name="mobilepage" width="4" height="4" bgcolor="0x5e5e5e"
extends="spatialnav" >
<method name="getCanvasFocusRect">
var rect = [ this.getAttributeRelative('x', canvas) - 3,
this.getAttributeRelative('y', canvas) - 3,
this.getAttributeRelative('width', canvas) +
6,
this.getAttributeRelative('height', canvas)
+ 6];
>>> return rect;
</method>
...
Sounds like an issue with the compiler.
P T Withington wrote:
Change 20080313-ptw-5 by [EMAIL PROTECTED] on 2008-03-13
10:54:50 EDT
in /Users/ptw/OpenLaszlo/ringding-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: LZX classes as JS2 classes
New Features: The tag compiler now emits LZX classes as JS2 class
declarations
Bugs Fixed:
LPP-1587 'ECMA4: Compile LZX declarations as JS
declarations' (partial)
Technical Reviewer: [EMAIL PROTECTED] (pending)
QA Reviewer: [EMAIL PROTECTED] (pending)
Doc Reviewer: [EMAIL PROTECTED] (pending)
Documentation: TBD
Release Notes: TBD
Details:
Highlights: The tag compiler now emits user classes as a JS2
class declaration. UserClass.lzs is dead. Setters are now just
methods on a class with a distinctive name, so the whole setters
table inheritance mechanism is gone. Early/delayed setters is a
private protocol between LzNode and LzView. All classes have a
uniorm 'namespace' naming scheme: $lzc$class_<tagname>, old LFC
class names are maintained for compatibility, but there are NO
global class names any more. All user code will have to be
updated to use lz.<tagname> to address classes for `new` or
`instanceof` tests.
[Details TBD]
Tests:
smokecheck has one failure regarding placement, amazon fails in
dhtml, I suspect due to the placement problem.
Files:
M test/smoke/regression.lzl
M test/smoke/all_setters.lzl
M test/smoke/getters-setters.lzl
M test/attribute-override-1.lzx
M WEB-INF/lps/lfc/kernel/swf/LzLibrary.lzs
M WEB-INF/lps/lfc/kernel/dhtml/LzLibrary.js
M WEB-INF/lps/lfc/kernel/swf9/LzLibrary.lzs
M WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/lfc/core/UserClass.lzs
M WEB-INF/lps/lfc/views/LzInputText.lzs
M WEB-INF/lps/lfc/views/LzScript.lzs
M WEB-INF/lps/lfc/views/LzText.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
M WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
M WEB-INF/lps/lfc/helpers/LzCommand.lzs
M WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
M WEB-INF/lps/lfc/helpers/LzState.lzs
M WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
M WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
M WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
M WEB-INF/lps/lfc/data/LzReplicationManager.lzs
M WEB-INF/lps/lfc/data/platform/swf/LzConnectionDatasource.lzs
M WEB-INF/lps/lfc/data/platform/swf/LzConnection.lzs
M WEB-INF/lps/lfc/data/LzDatapointer.lzs
M WEB-INF/lps/lfc/data/LzDataText.lzs
M WEB-INF/lps/lfc/data/LzDataRequest.lzs
M WEB-INF/lps/lfc/data/LzDataElement.lzs
M WEB-INF/lps/lfc/data/LzDataProvider.lzs
M WEB-INF/lps/lfc/data/LzDataset.lzs
M WEB-INF/lps/lfc/data/LzDatapath.lzs
M WEB-INF/lps/lfc/data/LzHTTPDatasource.lzs
M WEB-INF/lps/lfc/data/LzParam.lzs
M WEB-INF/lps/lfc/compiler/Class.lzs
M WEB-INF/lps/server/src/org/openlaszlo/xml/internal/Schema.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/
JavascriptGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/ScriptCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/ScriptClass.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/
ClassCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M lps/components/queens-charts/barchart.lzx
M lps/components/queens-charts/linechart.lzx
M lps/components/queens-charts/shared/dataseries.lzx
M lps/components/queens-charts/shared/basechartbacking.lzx
M lps/components/queens-charts/shared/basechart.lzx
M lps/components/queens-charts/shared/wholepie.lzx
M lps/components/queens-charts/shared/legend.lzx
M lps/components/queens-charts/piechart.lzx
M lps/components/rpc/rpc.lzx
M lps/components/rpc/xmlrpc.lzx
M lps/components/debugger/newcontent.lzx
M lps/components/debugger/scrollingtext.lzx
M lps/components/charts/common/dataseries.lzx
M lps/components/charts/common/chart.lzx
M lps/components/incubator/fisheye_lib.lzx
M lps/components/incubator/gradientview.lzx
M lps/components/incubator/autocompletecombobox.lzx
M lps/components/incubator/test/tooltipmanager-test.lzx
M lps/components/incubator/opttree/opttree.lzx
M lps/components/incubator/colorpicker.lzx
M lps/components/incubator/tooltipmanager.lzx
M lps/components/incubator/baseradio.lzx
M lps/components/incubator/rich-text/test/richtexteditarea-
test.lzx
M lps/components/incubator/rich-text/linkdialog.lzx
M lps/components/incubator/validators/validatingForm.lzx
M lps/components/incubator/validators/basevalidator.lzx
M lps/components/incubator/uploader/example/test-
fileuploadlist.lzx
M lps/components/incubator/uploader/example/test-
multiplefileupload.lzx
M lps/components/incubator/uploader/multiplefileupload.lzx
M lps/components/extensions/av/mediastream.lzx
M lps/components/extensions/av/videoview.lzx
M lps/components/extensions/av/rtmpconnection.lzx
M lps/components/base/basescrollbar.lzx
M lps/components/base/swatchview.lzx
M lps/components/base/basetree.lzx
M lps/components/base/componentmanager.lzx
M lps/components/base/basecomponent.lzx
M lps/components/base/basetabslider.lzx
M lps/components/base/baselist.lzx
M lps/components/base/basegrid.lzx
M lps/components/base/basetabs.lzx
M lps/components/base/basedatacombobox.lzx
M lps/components/base/style.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080313-ptw-5.tar
--
Regards,
Max Carlson
OpenLaszlo.org
