Not approved - swf9 fails to build:

lzl:
[echo] Compiling /Users/maxcarlson/openlaszlo/trunk-clean/lps/includes/lfc/LFC9.swc [java] Executing compiler: (cd /tmp/lzswf9/lzgen39146; /Users/maxcarlson/openlaszlo/devildog/lps/flex2/bin/compc -compiler.show-actionscript-warnings=false -compiler.source-path+=/tmp/lzswf9/lzgen39146 -debug=true -output /tmp/lzswf9/lzgen39146/app.swc -include-classes LzMessage LzFormatter LzDeclaredEventClass LzNullEvent LzInitExpr LzOnceExpr LzConstraintExpr LzStyleExpr LzStyleAttr LzStyleAttrBinder LzStyleIdent LzInheritedHash LzParsedPath LzDataset LzDataNode LzDataAttrBind LzDatapath LzDataElement LzDataText LzCSSStyle LzBrowser LzFocus LzTrack lzcoreutils LzTimer LzNode LzDelegate LzEvent LzUtils DebugExec LFCApplication LzIdleKernel LzSprite LzTextSprite LzInputTextSprite LzFontManager LzXMLParser LzXMLTranslator LzHTTPLoader LzKeyboardKernelClass LzView LzText LzInputText LzViewLinkage LzCanvas LzScript LzAnimatorGroup LzAnimator LzLayout LzFont LzState LzInstantiatorClass LzGlobalMouse LzModeManager LzURL LzKeysClass LzIdleClass Debug \$lzsc\$mixin\$LzFormatter\$LzView \$dhtml canvas fuchsia white \$swf7 LzKeys LzDeclaredEvent \$swf8 \$svg LzKeyboardKernel black global teal maroon silver LzInstantiator \$profile \$runtime blue lzOptions purple LzIdle \$debug \$j2me aqua red lzconsole \$as3 olive \$js1 yellow gray \$as2 navy green ConstructorMap lime \$swf9 lz LzResourceLibrary _Copyright)
     [java] compiler output:
[java] Loading configuration file /Users/maxcarlson/openlaszlo/devildog/lps/flex2/frameworks/flex-config.xml

     [java] ERRORS:
[java] Compiler error: at 1256 [/tmp/lzswf9/lzgen39146/LzView.as: 351]: Error: Incompatible override.
     [java]
     [java] override function destroy (recursiveCall = null) {
     [java]                    ^

[java] Compiler error: at 534 [/tmp/lzswf9/lzgen39146/LzAnimatorGroup.as: 211]: Error: Incompatible override.
     [java]
     [java] override function destroy (recursiveCall = null) {
     [java]                    ^

[java] Compiler error: at 325 [/tmp/lzswf9/lzgen39146/LzState.as: 120]: Error: Incompatible override.
     [java]
     [java] override function destroy (recursiveCall = null) {
     [java]                    ^

     [java] FAIL: compiler returned 3
     [java] Done executing compiler
[java] Intermediate file /tmp/lzswf9/lzgen39146/app.swc: does not exist [java] Exception compiling scriptfile: : org.openlaszlo.sc.CompilerError: 1256 [/tmp/lzswf9/lzgen39146/LzView.as: 351]: Error: Incompatible override. [java] , in line: override function destroy (recursiveCall = null) {534 [/tmp/lzswf9/lzgen39146/LzAnimatorGroup.as: 211]: Error: Incompatible override. [java] , in line: override function destroy (recursiveCall = null) {325 [/tmp/lzswf9/lzgen39146/LzState.as: 120]: Error: Incompatible override. [java] , in line: override function destroy (recursiveCall = null) { [java] org.openlaszlo.sc.CompilerException: : org.openlaszlo.sc.CompilerError: 1256 [/tmp/lzswf9/lzgen39146/LzView.as: 351]: Error: Incompatible override. [java] , in line: override function destroy (recursiveCall = null) {534 [/tmp/lzswf9/lzgen39146/LzAnimatorGroup.as: 211]: Error: Incompatible override. [java] , in line: override function destroy (recursiveCall = null) {325 [/tmp/lzswf9/lzgen39146/LzState.as: 120]: Error: Incompatible override. [java] , in line: override function destroy (recursiveCall = null) {
     [java]     at org.openlaszlo.sc.Compiler.compile(Compiler.java:390)
     [java]     at org.openlaszlo.sc.lzsc.compile(lzsc.java:110)
     [java]     at org.openlaszlo.sc.lzsc.compile(lzsc.java:322)
     [java]     at org.openlaszlo.sc.Main.main(Main.java:10)
     [java] Compilation aborted.

BUILD FAILED
/Users/maxcarlson/openlaszlo/trunk-clean/build.xml:529: The following error occurred while executing this line: /Users/maxcarlson/openlaszlo/trunk-clean/WEB-INF/lps/lfc/build.xml:122: The following error occurred while executing this line: /Users/maxcarlson/openlaszlo/trunk-clean/WEB-INF/lps/lfc/build.xml:79: Java returned: 1


Henry Minsky wrote:
This change fixes the redeclaration of instance vars, and some other stuff, but there seems to be one bug, when I run smokecheck, I get a warning at runtime that _enabled is not
defined in

ERROR @base/basebutton.lzx#212: reference to undefined variable '_enabled'
ERROR @base/multistatebutton.lzx#32: reference to undefined variable '_enabled'


If you have any idea where that is coming from please tell me ... I'm looking into it


Change 20080329-hqm-o by [EMAIL PROTECTED] on 2008-03-29 14:33:23 EDT
    in /Users/hqm/openlaszlo/trunk4
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: change to class compiler, declarations of some methods

New Features:

Bugs Fixed:

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

+ add check to ClassCompiler so it doesn't redeclare vars that are declared in a superclass

+ make signatures match on all destroy() methods in component library

+ make some other methods signature match for checkbox


Tests:

smoke
grid example

test/swf9/checkbox, check that it no longer warns about "frame" instance var redeclaration in swf9

Files:
A      test/swf9/checkbox.lzx
M      WEB-INF/lps/schema/lfc.lzx
M      WEB-INF/lps/lfc/core/LzNode.lzs
M      WEB-INF/lps/lfc/views/LzText.lzs
M      WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassCompiler.java
M      lps/components/lz/list.lzx
M      lps/components/utils/layouts/simplelayout.lzx
M      lps/components/base/basebutton.lzx
M      lps/components/base/basetabelement.lzx
M      lps/components/base/basescrollbar.lzx
M      lps/components/base/multistatebutton.lzx
M      lps/components/base/basetree.lzx
M      lps/components/base/basecomponent.lzx
M      lps/components/base/basewindow.lzx
M      lps/components/base/submit.lzx
M      lps/components/base/basetrackgroup.lzx
M      lps/components/base/baseformitem.lzx
M      lps/components/base/basetabs.lzx
M      lps/components/base/basedatacombobox.lzx
M      examples/components/grid_example.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080329-hqm-o.tar

--
Regards,
Max Carlson
OpenLaszlo.org

Reply via email to