Apart from that, I've search all references of "LzConstraintExpr" in the lfc: - "LzReplicationManager#construct(..)" uses "LzConstraintExpr", but actually "LzAlwaysExpr" is meant, right? (doesn't make sense to use a style for a datapath?!) - "LzNode#releaseConstraint(..)" should be ok, so this method can be used to remove an always-constraint and a style-constraint - "LzState#__LZapplyArgs(..)" needs to be synchronized to "LzNode#__LZapplyArgs(..)"
- "LzState#apply()" and "LzState#remove()" should be ok, too

On 4/14/2008 5:59 PM, André Bargull wrote:
Sorry, I cannot approve this changeset, because it contains a plain lie! :-)

/**
 * Private class used to define a 'style' (_*and as a subclass, an
 * 'always*_) constraint
 * @access private
 */
class LzConstraintExpr extends LzOnceExpr {

And later:
/**
 * Private class used to define an 'always' constraint (which also has
 * a dependency method)
 * @access private
 */
class LzAlwaysExpr extends _*LzOnceExpr *_{


On 4/14/2008 1:34 PM, P T Withington wrote:
Change 20080411-ptw-1 by [EMAIL PROTECTED] on 2008-04-11 18:44:33 EDT
    in /Users/ptw/OpenLaszlo/ringding-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Silence CSS style warning

Bugs Fixed:

Technical Reviewer: [EMAIL PROTECTED] (pending)
QA Reviewer: [EMAIL PROTECTED] (pending)

Details:
    Create new subclass of LzConstraintExpr, LzAlwaysExpr to hold
    constraints with dependencies.


Tests:
    Test case from bug

Files:
M      WEB-INF/lps/lfc/core/LzNode.lzs
M      WEB-INF/lps/lfc/core/LzDefs.lzs
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080411-ptw-1.tar


Reply via email to