approved! On Sat, Apr 19, 2008 at 1:12 PM, André Bargull <[EMAIL PROTECTED]> wrote:
> Change 20080419-bargull-8 by [EMAIL PROTECTED] on 2008-04-19 01:56:01 > in /home/Admin/src/svn/openlaszlo/trunk > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: data-binding and -selection broken > > New Features: > > Bugs Fixed: LPP-5819 - swf: dhtml : components: grid_example: Cannot edit > text in the weather/contacts tab > > Technical Reviewer: henry > QA Reviewer: promanik > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > part 1: The GridText > In the old days, a datapath (as an attribute) was marked with > "_ignoreAttribute" when there was also a datapath (as a tag). This was done > by LzFixTags, since rev. #5,735 this is made by "NodeModel#updateAttrs()" > (see LPP-3482). > But in gridtext, the datapath (as an attribute) is a constraint, so in > earlier releases it was stored in the "$refs"-object and therefore it wasn't > smashed by LzFixTags. > Now, all instance-attributes come in one object, so there is no special > "$refs" object anymore. That's why the constraint is removed at compile > time. > > part 2: updateData + setSelected > "updataData" and "setSelected" were kind of dynamic functions, now they're > placed in LzNode to make swf9 happy. > A couple of changes were necessary: > > lfc.lzx - update schema: > Moved "setSelected" and "updataData" into LzNode. > Removed "updataData" from LzDatapath and LzInputText. > > LzMiniNode.lzs: > Don't hoist "_selstate" up into LzMiniNode, moved to LzDatapath resp. > LzDataNode and re-renamed to "sel". > > LzNode.lzs: > Added "setSelected" and "updataData" methods. > > LzDataNode.lzs: > Re-added "sel" property. > > LzDatapath.lzs: > Re-added "sel" property. > Updated "updataData", "setClonePointer" and "setSelected" methods. > Added new internal method "__LZupdateData", so we don't have to struggle > with changing the updataData-API. > > LzReplicationManager.lzs: > Moved code from "updataData" to "__LZupdateData". > > LzDataAttrBind.lzs: > Mark "updataData" as overrriden. > Added "__LZupdateData" to mimic LzDatapath. > > LzDatapointer.lzs: > Check for "nodeType". > > LzDataSelectionManager.lzs: > Update doc-comment. > > LzInputText.lzs: > Mark "updataData" as overrriden. > > gridtext.lzx: > Uses now visibility to control visible-status. > > LaszloView.lzs: (not part of the bug) > Added comment how to restore default cursor. > > > Tests: > ant runlzunit > ant lztest > alldata.lzx > testcases from bugreport > compile swf9 > > Files: > M WEB-INF/lps/schema/lfc.lzx > M WEB-INF/lps/lfc/core/LzMiniNode.lzs > M WEB-INF/lps/lfc/core/LzNode.lzs > M WEB-INF/lps/lfc/views/LzInputText.lzs > M WEB-INF/lps/lfc/views/LaszloView.lzs > M WEB-INF/lps/lfc/data/LzDataNode.lzs > M WEB-INF/lps/lfc/data/LzReplicationManager.lzs > M WEB-INF/lps/lfc/data/LzDatapointer.lzs > M WEB-INF/lps/lfc/data/LzDatapath.lzs > M WEB-INF/lps/lfc/data/LzDataAttrBind.lzs > M WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs > M lps/components/lz/gridtext.lzx > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20080419-bargull-8.tar > > -- > -- Henry Minsky Software Architect [EMAIL PROTECTED]
