Ok, the only public function in LzDataNode is
"LzDataNode.stringToLzData(..)"...
So I'd like to propose:
- move "LzDataNode.stringToLzData(..)" to "LzDataElement"
- rename LzDataNodeMixin (back) to LzDataNode
- move ELEMENT_NODE, TEXT_NODE, DOCUMENT_NODE to LzDataNode as const
(this is where they actually belong to [1])
(and it is more compliant to 4.0.12 [2])
=> that way, the only API-change is about "stringToLzData" and user
programs which use
- "LzDataNode.ELEMENT_NODE" etc.
- and "p is LzDataNode" will still continue to work.
Just my 2 cents.
[1]
"http://www.w3.org/TR/2004/REC-DOM-Level-3-Core-20040407/core.html#ID-1950641247"
[2]
"http://svn.openlaszlo.org/openlaszlo/tags/4.0.12/WEB-INF/lps/lfc/data/LzDataNode.lzs"
On 5/8/2008 4:46 PM, André Bargull wrote:
This is a public-API change, sure you still want to do this? Will
<strike>possibly</strike> surely break user applications.
Change 20080508-hqm-o by [EMAIL PROTECTED] on 2008-05-08 09:28:35 EDT
in /Users/hqm/openlaszlo/trunk5
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: remove obsoleted LzDataNode class, update docs
New Features:
Bugs Fixed:
Technical Reviewer: ptw
QA Reviewer: pbr
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
The LzDataNode class had pretty much all it's functionality moved to
lzDataNodeMixin, and there
were just a couple of static properties left on LzDataNode. I moved
these to lzDataElement, and updated
the table of contents to not point to LzDataNode anymore.
Tests:
smokecheck
ant lztest
test/lfc/data/alldata.lzx
Files:
M WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs
M WEB-INF/lps/lfc/services/LzBrowser.lzs
M WEB-INF/lps/lfc/helpers/LzCommand.lzs
M WEB-INF/lps/lfc/data/LzDatapointer.lzs
M WEB-INF/lps/lfc/data/LzDataText.lzs
M WEB-INF/lps/lfc/data/LzDataNode.lzs
M WEB-INF/lps/lfc/data/LzDataElement.lzs
M WEB-INF/lps/lfc/data/LzDataset.lzs
M docs/src/nav/toc.xml
M lps/components/rpc/ajax.lzx
M lps/components/rpc/library/swf/rpc.js
M lps/components/rpc/library/rpc.js
M lps/components/lzunit/lzunit.lzx
M lps/components/utils/replicator/replicator.lzx
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20080508-hqm-o.tar