I was a bit worried, because LzTimeKernel was at the top of the list,
which gives a higher priority, and now it is at the very bottom, so it
has the lowest priority among the kernel files. But when think about it,
LzTimeKernel is fairly new, so there actually shouldn't be any
conflicts. However, just ignore my "nervous twitch". :-)
On 5/8/2008 5:35 PM, Philip Romanik wrote:
I think we are ok. I moved LzTimeKernel to the bottom because the code
looks for LzSprite.prototype.quirks when the file is loaded. Strictly
speaking I only needed to move down until after __updateQuirks() is
called (inside of LzSprite.js).
Not approved!
First include in "Library.lzs" is now "LFC.js" and in this file,
there is the definition of the global "getTimer()"-function, which
refers to LzTimeKernel. So you cannot make LzTimeKernel the last
include without further adjustments.
> Change 20080507-Philip-8 by [EMAIL PROTECTED] on 2008-05-07 20:54:59 EDT
> in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: runlzteset fails because isIE is missing
>
> New Features:
>
> Bugs Fixed: LPP-5954
>
> Technical Reviewer: max
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> The browser detect code at the front of LzTimeKernel.js fails in rhino
> because Lz.__BrowserDetect does not exist. My first solution was to
> modify rhino.js, but this causes other code to execute in the kernel
> (in bLzSprite.__updateQuirks()). I added a new quirk and it is only
> true for IE. LzTimKernel.js was the first loaded kernel file and I
> moved it to the last because it now refers to something in LzSprite.
>
> Library.lzs: Move LzTimeKernel to the end to remove forward reference
> LzSprite.js: Add ie_timer_closure quirk which is true for IE
> LzTimeKernel.js: use ie_timer_closure quirk instead of
> Lz.__BrowserDetect
>
>
> Tests:
> The isIE error is gone from running buildtools/runlztest.sh. I see
> other errors when I run this but they don't appear to be caused by
this issue.
>
> Files:
> M WEB-INF/lps/lfc/kernel/dhtml/LzTimeKernel.js
> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M WEB-INF/lps/lfc/kernel/dhtml/Library.lzs
>
> Changeset:
> http://svn.openlaszlo.org/openlaszlo/patches/20080507-Philip-8.tar
