Re: [Laszlo-dev] For Review: Change 20080508-hqm-t Summary: fix for menu attribute "command" type, and add more back compatibility for LzDataNode constants

[P T Withington]

Approved.

I wonder if you could just use regexp for your whitespace trimmer:

var trimpat:RegExp = /^\s*(.*?)\s*$/;
function trim (s) {
  return (trimpat.exec(s)[1]);
}

On 2008-05-08, at 13:19 EDT, Henry Minsky wrote:

Change 20080508-hqm-t by [EMAIL PROTECTED] on 2008-05-08 13:17:08 EDT
   in /Users/hqm/openlaszlo/trunk5
   for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: fix for menu attribute "command" type, and add more back compatibility for LzDataNode constants

New Features:

Bugs Fixed:

Technical Reviewer: ptw
QA Reviewer: andre
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

+ put back copies of the LzDataNode.ELEMENT_NODE constants for back compatibility

(not sure how to generate deprecation warnings for them yet)

+ back out Max's change to menuitem which used "command" as an attribute type

+ make a kernel-local copy of the "trim" method in swf9, so we don't have to call into the LFC for it.

Tests:

ant runlzunit


Files:
M      WEB-INF/lps/lfc/kernel/swf9/LzXMLTranslator.as
M      WEB-INF/lps/lfc/data/LzDataNode.lzs
M      WEB-INF/lps/lfc/data/LzDataElement.lzs
M      lps/components/lz/menu.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080508-hqm-t.tar