Do you want me to check this in, even though it breaks constraints to
canvas attributes in Flash?
P T Withington wrote:
Approved.
On 2008-05-23, at 12:46 EDT, Max Carlson wrote:
Change 20080523-maxcarlson-x by [EMAIL PROTECTED] on 2008-05-23
09:25:04 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATED: Try #2 at canvas subclasses
Bugs Fixed: LPP-5186 'Runtime error using script function within
attribute value declaration for IE7 DHTML in nightly build 7411'
Technical Reviewer: ptw (pending)
QA Reviewer: promanik (pending)
Details:
Rework canvas subclasses to not try to override supeclass properties
UPDATED - Use standard constructor signature in LaszloCanvas.lzs
Tests:
Amended test case from bug. swf9/hello.
Note that you'll need the patch from For Review: Change
20080523-maxcarlson-D Summary: Fix embedding in IE applied before IE
will run.
Also, I noticed this breaks constraints to the canvas in swf7/8,
e.g. <canvas><window width="100%" height="100%"/></canvas>.
I'm sending this out because it does fix swf9 and it works in
dhtml, but Tucker should probably take another shot at it to make sure
constraints to canvas attributes work in Flash.
Files:
M WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M WEB-INF/lps/server/src/org/openlaszlo/compiler/CanvasCompiler.java
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20080523-maxcarlson-x.tar
--
Regards,
Max Carlson
OpenLaszlo.org
