My reasoning:

1. We changed the default for resize for text to be true if you did not have an explicit size in 4.x 2. Normally you would give input text a size, in which case it will not resize

That seems pretty natural to me: that if you don't specify a size, it sizes to the content, and if you do specify a size, it stays that size (unless you specifically ask for it to resize).

On 2008-06-23, at 19:22 EDT, André Bargull wrote:

Approved,
but I don't think an inputtext should resize by default, because users don't expect this behaviour (it didn't work that way before, neither in LPS3 nor in LPS4).


On 6/23/2008 11:54 PM, P T Withington wrote:
Change 20080623-ptw-V by [EMAIL PROTECTED] on 2008-06-23 17:20:38 EDT
   in /Users/ptw/OpenLaszlo/ringding-clean
   for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Make input text resize by default, and actually resize

Bugs Fixed:
LPP-5678 'inputtext resize not working'

Technical Reviewer: [EMAIL PROTECTED] (pending)
QA Reviewer: hminsky (pending)

Details:
   swf/LzTextSprite.as, swf/LzInputTextSprite.as: Share a single
   implementation of setText.

   swf/LzInputTextSprite: default this.resize, args.width, and
   args.height the same way LzTextSprite does.

LzText.lzs, LzIntputText.lzs: Share a single implementation of setText.

Tests:
   ant lztest, smokecheck, test case from bug (works in swf8, dhtml,
   and swf9 (modulo LPP-6505).

Files:
M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
M      WEB-INF/lps/lfc/kernel/swf/LzInputTextSprite.as
M      WEB-INF/lps/lfc/views/LzInputText.lzs
M      WEB-INF/lps/lfc/views/LzText.lzs


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080623-ptw-V.tar



Reply via email to