P T Withington wrote:
Henry might be a better reviewer than I for this level of swf9. But what you say makes sense. Comments:

1) IWBNI the arguments to copyBitmap were documented. I can't guess what the mysterious (and apparently unused) `m` argument does. Should `to` and `m` be optional?

Done.

2) I'm always leery of polling. Is there not some event sent when a resource is loaded that could be reacted to?

Not that I could find :(. There's almost no documentation on the [Embed] pragma, much less what happens after you 'new' one of the magic resource objects.

Otherwise, approved.

On 2008-07-16, at 02:11EDT, Max Carlson wrote:

Change 20080715-maxcarlson-P by [EMAIL PROTECTED] on 2008-07-15 22:11:31 PDT
   in /Users/maxcarlson/openlaszlo/trunk-clean
   for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix onclick event for buttons in Flash 9

Bugs Fixed: LPP-6505 - Button events clogged up in swf9?

Technical Reviewer: promanik
QA Reviewer: ptw

Details: LzSprite.as - Creating and destroying child display objects interferes with the mouse. Instead, create a bitmap object that holds the resource data and replace its contents directly. Compiled assets take a while to instantiate, added a callback to deal with this.

LzGlobalMouse.as - Add missing event.

Tests: See LPP-6505.  Lzpix and other examples running in swf9 look good!

Files:
M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
M      WEB-INF/lps/lfc/services/LzGlobalMouse.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080715-maxcarlson-P.tar


--
Regards,
Max Carlson
OpenLaszlo.org

Reply via email to