Sorry for the late review -
Approved as long there are tests for the various code paths.
I see why you wanted a macro expander for this, it's tangled stuff.
On Jul 17, 2008, at 8:58 PM, P T Withington wrote:
Change 20080717-ptw-e by [EMAIL PROTECTED] on 2008-07-17
19:51:51 EDT
in /Users/ptw/OpenLaszlo/dingdong-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Reinstate setAttribute inlining
Bugs Fixed:
LPP-5622 'Re-enable setAttribute inlining'
Technical Reviewer: dda (pending)
QA Reviewer: promanik (pending)
Details:
LzEventable: remove debug code
JavascriptGenerator, CodeGenerator: update setAttribute inlining
code to match the new way, and enable it.
Tests:
smokecheck, ant lztest
Files:
M WEB-INF/lps/lfc/core/LzEventable.lzs
M WEB-INF/lps/server/src/org/openlaszlo/sc/
JavascriptGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
M WEB-INF/lps/server/build.xml
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080717-ptw-e.tar
--
Donald Anderson
Systems Developer
[EMAIL PROTECTED]
