Approved with some minor comments:
================
+ public function runToplevelDefinitions() {
+ // overridden by SWF9ParseTreePrinter
+ }
I think it would be more helpful and accurate to say 'overridden by
function generated in the SWF9 script compiler'
================
-function LzInstantiateView(e, tn = 1)
+var LzInstantiateView = function (e, tn = 1)
{
canvas.initiatorAddNode( e , tn );
}
Why do we have to do this? It's less 'class-y', bucking our usual
trend.
================
+++ WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9ParseTreePrinter.java
(working copy)
@@ -56,6 +56,9 @@
boolean islib = false;
public Config setIsLib(boolean value) { islib = value; return
this; }
+ boolean isloadableLib = false;
+ public Config setIsLoadableLib(boolean value) { isloadableLib =
value; return this; }
+
isloadableLib is never used. Is this work in progress?
================
+++ WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
(working copy)
+ "runToplevelDefinitions()\n" +
I like to see terminating ';' -- even in javascript :-)
================
On Nov 18, 2008, at 1:37 AM, Henry Minsky wrote:
Change 20081118-hqm-v by [EMAIL PROTECTED] on 2008-11-18 01:27:31 EST
in /Users/hqm/openlaszlo/trunk4
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: checkpoint of swf9 runtime loadable libraries
New Features:
Bugs Fixed: LPP-7291
Technical Reviewer: dda
QA Reviewer: ptw
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
+ rearranged how the main swf9 application class is called
+ Made SWF9ParseTreePrinter put all top level definitions into a new
method, named "runToplevelDefinitions",
instead of putting them into the app constructor. This gives more
control over when they are run, so
that the loadable library code path can first set up some globals
before running them.
+ created a base class for runtime loadable libraries,
LzBaseLoadableLib
+ got the loader working for swf9 LzLibrary.as, but the class still
needs to be cleaned up and
make a common LzLibrary.lzs class, merged with the other runtimes.
+ runtime loading of tags (classes) is working, but loading of view
instances and resources is not
implemented yet
Tests:
test/snippets/import-class.lzx in swf8,swf9
test/smoke/smokecheck swf8,swf9
lzpix in swf8,swf9
Files:
M WEB-INF/lps/lfc/kernel/swf9/LFCApplication.as
A WEB-INF/lps/lfc/kernel/swf9/LzBaseLoadableLib.as
M WEB-INF/lps/lfc/kernel/swf9/Library.lzs
M WEB-INF/lps/lfc/kernel/swf9/LzLibrary.as
M WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs
M WEB-INF/lps/lfc/glue/LaszloInitiator.lzs
M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/
SWF9ParseTreePrinter.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/
CompilationEnvironment.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/
ImportCompiler.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081118-hqm-v.tar
--
Don Anderson
Java/C/C++, Berkeley DB, systems consultant
voice: 617-547-7881
email: [EMAIL PROTECTED]
www: http://www.ddanderson.com
